From 4c8766d7a5be8a199ba39a51ccdf7c270e2e59bc Mon Sep 17 00:00:00 2001 From: Jonathan Norris Date: Tue, 17 Nov 2026 14:28:47 -0500 Subject: [PATCH 1/2] ci: run PR checks on pull_request so release-please PRs get them --- .github/workflows/benchmark.yml | 5 ++++- .github/workflows/check-semantic.yml | 6 +++++- .github/workflows/test_examples.yml | 5 ++++- .github/workflows/unit_test.yml | 5 ++++- 4 files changed, 17 insertions(+), 4 deletions(-) diff --git a/.github/workflows/benchmark.yml b/.github/workflows/benchmark.yml index b486791..a9ec14a 100644 --- a/.github/workflows/benchmark.yml +++ b/.github/workflows/benchmark.yml @@ -1,6 +1,9 @@ name: Benchmark -on: [push] +on: + push: + branches: [main] + pull_request: permissions: contents: read diff --git a/.github/workflows/check-semantic.yml b/.github/workflows/check-semantic.yml index 682b334..4d39514 100644 --- a/.github/workflows/check-semantic.yml +++ b/.github/workflows/check-semantic.yml @@ -1,10 +1,14 @@ name: Semantic PR on: - pull_request_target: + # pull_request, not pull_request_target: GitHub never starts pull_request_target + # runs for PRs opened with GITHUB_TOKEN (release-please), but it does start + # pull_request runs, which wait for approval like the other checks. + pull_request: types: - opened - edited - synchronize + - reopened permissions: pull-requests: read jobs: diff --git a/.github/workflows/test_examples.yml b/.github/workflows/test_examples.yml index 21045e5..4d245c0 100644 --- a/.github/workflows/test_examples.yml +++ b/.github/workflows/test_examples.yml @@ -1,6 +1,9 @@ name: Test Examples -on: [push] +on: + push: + branches: [main] + pull_request: permissions: contents: read diff --git a/.github/workflows/unit_test.yml b/.github/workflows/unit_test.yml index 3ce77d6..efa3eb3 100644 --- a/.github/workflows/unit_test.yml +++ b/.github/workflows/unit_test.yml @@ -1,6 +1,9 @@ name: Unit Tests -on: [push] +on: + push: + branches: [main] + pull_request: permissions: contents: read From 65f1127d7aa78485940ae51ff3d159aee4e6d144 Mon Sep 17 00:00:00 2001 From: Jonathan Norris Date: Tue, 17 Nov 2026 14:32:03 -0500 Subject: [PATCH 2/2] ci: shorten semantic workflow comment --- .github/workflows/check-semantic.yml | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/.github/workflows/check-semantic.yml b/.github/workflows/check-semantic.yml index 4d39514..9d6efdd 100644 --- a/.github/workflows/check-semantic.yml +++ b/.github/workflows/check-semantic.yml @@ -1,8 +1,6 @@ name: Semantic PR on: - # pull_request, not pull_request_target: GitHub never starts pull_request_target - # runs for PRs opened with GITHUB_TOKEN (release-please), but it does start - # pull_request runs, which wait for approval like the other checks. + # pull_request_target never runs on release-please PRs (opened with GITHUB_TOKEN) pull_request: types: - opened