Repository navigation
Conversation
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A strong-named .NET Framework assembly can only reference strong-named assemblies, so anyone with a strong-named app on .NET Framework currently can't use HTML Renderer at all. On .NET Core and .NET 5+ the runtime ignores strong names, so there it changes nothing.
All assemblies are now signed with
Source/HtmlRenderer.snk, public key token8ad04eaa796bce90. The key is committed on purpose, strong names aren't a security feature and Microsoft's guidance for open source libraries is to keep the key in the repo, same as HtmlKit and PDFsharp do. Additionally:PublicKeyis set inDirectory.Build.props, so the existingInternalsVisibleToitems get the key without listing it each timeDemo.CommonNote that a strong name changes the assembly identity, so this is a breaking change and belongs into 2.0. Going forward,
AssemblyVersionhas to stay at2.0.0.0for all of 2.x, any change of it breaks the binding of strong-named references on .NET Framework. The NuGet version andFileVersioncan change freely.Closes #292
How to test this PR?
CI should succeed.
[AssemblyName]::GetAssemblyName("HtmlRenderer.dll").FullNameshould end withPublicKeyToken=8ad04eaa796bce90.