Repository navigation
Make fn_read_fish_edit_list an inline TVF (fish page habitat timeout) - #93
Merged
Merged
Conversation
The multi-statement version built all 1,063 fish into a table variable with 10 UPDATEs before wfFishViewer.LoadHabitat's WHERE fish_id applied; the fish page hit the 30 s command timeout 24 times on prod since 2026-10-27. Same columns in the same order; one fish 1,841 ms -> 2 ms locally. Tests: unit_test@FishEditList.sql (3; TEST 1 failed on the old function). LIVE on prod 2026-11-15 (1,063 rows identical before/after). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dbo.fn_read_fish_edit_list()built the habitat row for every fish (1,063) into a table variable with 10 UPDATEs beforewfFishViewer.LoadHabitat'sWHERE fish_id =applied. The fish page hit the 30 s command timeout 24 times on prod since 2026-10-27 (plus 4 inLoadUnEditedFish, same function).unit_test@FishEditList.sql(3 tests): TEST 1 failed on the old function, all pass now;unit_test@FishEditor.sqlstill passes.Full suite: no FAIL lines; unrelated pre-existing errors in
unit_test@CatchMemo.sqlTEST 43 and the untrackedunit_test@FishReasoningJson.sql.🤖 Generated with Claude Code