Repository navigation
Let the B1 app frame its Lessons tab sign-in again - #517
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
/b1/login now signs in from #jwt itself and never mounts the Login form. With no jwt, a rejected jwt, an MFA challenge, or ?action=/?auth=, it replaces the frame with /login, which refuses framing.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the October security headers, /login refuses framing, so the B1 mobile app's Lessons tab is blank for every church. This adds /b1/login, the same token handoff with no password form, under the already-frameable /b1/ path, and /login stays protected. The B1App change that points the tab here should deploy after this one.
ChurchApps/ChurchAppsSupport#1604