Repository navigation
Replace explicit any with real types and make no-explicit-any an error - #519
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes every explicit
anyfrom LessonsApp (161 → 0) and turns on@typescript-eslint/no-explicit-anyas an error. It is three commits; reviewing commit by commit is easiest.PlaylistFeedhad an unusedhandleChange, so I deleted it, and its state values are now discarded (the setters stay, so the existing fetch still runs).FormValuestype.LessonFeedDataInterface,ProviderStatsInterfaceandDownloadGeoInterface.null,CustomizationInterface.actionContentisstring | number, and the feed section/action types gainedid/sort/roleIdto match LessonsApi's models.churchCount/lessonCount, but the API returns{ providers, studies, lessons }. It's now correct.No
as unknown as,@ts-ignore,eslint-disableor!assertions were added, and theanychanges are meant to leave runtime behavior unchanged. The one spot to look at:CustomizationHelper's sort now comparesNumber(a.sort) < Number(b.sort). That is identical for numbers and nulls, and would only differ if sort values arrived as numeric strings.Checks:
tsc --noEmit0 errors,eslint src/clean,next buildsucceeds. Playwright was not run because this machine has no database.🤖 Generated with Claude Code