Repository navigation
Generate Images in C# Using ImageSharp: net11.0, pinned ImageSharp 3.1.12 and Drawing 2.1.7 - #2401
Open
vladimir-pecanac-main wants to merge 1 commit into
Conversation
…Drawing 2.1.7, run tests in CI Both projects move to net11.0. The library pins SixLabors.ImageSharp 3.1.12 and SixLabors.ImageSharp.Drawing 2.1.7, the newest versions without a build-time license check. DrawPolygon() gets three points, since the polygon closes itself. The test class drops the Live suffix so CI runs it, and the tests check pixels instead of comparing object references. Test packages updated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the GenerateImagesInCSharpUsingImageSharp sample to net11.0 and pins SixLabors.ImageSharp 3.1.12 and SixLabors.ImageSharp.Drawing 2.1.7, the newest versions that build without a license key; the restore still shows the six NuGet advisory warnings for ImageSharp 3.1.12, which stay warnings. DrawPolygon() now gets three points because the polygon closes itself, the test class is renamed to ImageServiceTests so CI runs its 10 tests, the reference comparison test is replaced by pixel checks, and the xUnit, test SDK and coverlet packages are updated.