Skip to content

Fix command disposal, parameter callbacks, handler-cache staleness, static properties, and type-map races - #2272

Merged
mgravell merged 1 commit into
mainfrom
fix/salvaged-community-fixes
Nov 20, 2026
Merged

mgravell merged 1 commit into
mainfrom
fix/salvaged-community-fixes

Conversation

@mgravell

Copy link
Copy Markdown
Member

Five small production fixes, each originally identified in community PRs by @alaricd (#2264, #2257, #2247, #2254, #2251). The production changes are adopted essentially as proposed — with the parameter-callbacks fix extended to the async call site those PRs missed — and the tests are rewritten against the repo's existing test infrastructure (SQL Server provider pair, the in-repo mock reader, and the existing WrappedReader fakes) rather than introducing a new test dependency.

Tests: 9 new (8 red on main, 1 sync-path guard), full suite 803 passed / 0 failed on net8.0 and net10.0 against real Postgres + SQL Server 2019 locally.

…tatic properties, and type-map races

Five small fixes, each identified by community PRs (credit: alaricd), re-tested
on the repo's existing test infrastructure:

- DbWrappedReader.DisposeAsync now disposes the wrapped command, mirroring the
  sync Dispose path; 'await using' on an ExecuteReaderAsync result previously
  leaked the command (#2185, community PR #2264)
- QueryMultiple / QueryMultipleAsync now pass custom IParameterCallbacks
  implementations to the GridReader, not just DynamicParameters, so OnCompleted
  fires for them (#2179, community PR #2257, extended to the async call site)
- AddTypeHandler purges compiled deserializer caches: a handler registered
  after a deserializer was compiled for a containing type is now honored
  (community PR #2247)
- public static properties on parameter objects are ignored: the emitted IL
  loads the instance before each getter call, which is an invalid program for
  a static getter (community PR #2254)
- AddTypeMap / RemoveTypeMap clone-and-swap now happens under a lock, so
  concurrent registrations cannot lose each other's updates (community PR #2251)

Fixes #2179, fixes #2185
@mgravell
mgravell merged commit 9eccc14 into main Nov 20, 2026
2 checks passed
@mgravell
mgravell deleted the fix/salvaged-community-fixes branch November 20, 2026 11:04
This was referenced Nov 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

1 participant