Skip to content

ci: run semantic PR check on pull_request - #209

Merged
jonathannorris merged 1 commit into
mainfrom
ci/semantic-pull-request
Nov 19, 2026
Merged

jonathannorris merged 1 commit into
mainfrom
ci/semantic-pull-request

Conversation

@jonathannorris

Copy link
Copy Markdown
Member

Summary

  • Semantic PR switches from pull_request_target to pull_request. GitHub never starts pull_request_target runs for PRs opened by github-actions[bot], so release-please PRs were stuck waiting on the required check. pull_request runs are created and wait for approval like the other checks.

Related Issues

Same fix as DevCycleHQ/python-server-sdk#128

@jonathannorris
jonathannorris requested a review from a team as a code owner November 19, 2026 19:37
Copilot AI balanced review requested due to automatic review settings November 19, 2026 19:37

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues were identified in the Semantic PR workflow trigger update.

No open issues 🎉

What changed in this PR

Updates the Semantic PR workflow trigger to address required checks remaining pending on release-please PRs.

Changes:

  • Switches the trigger from pull_request_target to pull_request.
  • Adds reopened to the existing PR event types.
  • Adds a comment explaining the intended rationale for the trigger change.
File Description
.github/​workflows/​checks.yml Changes the Semantic PR trigger and includes reopened PRs.

Review effort: Balanced

@jonathannorris
jonathannorris merged commit 760ee72 into main Nov 19, 2026
10 checks passed
@jonathannorris
jonathannorris deleted the ci/semantic-pull-request branch November 19, 2026 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants