Repository navigation
Conversation
Monitoring in-flight backup copies on a destination instance requires filtering ListBackupOperationsRequest by CopyBackupMetadata.
|
Here is the summary of changes. You are about to add 1 region tag.
This comment is generated by snippet-bot.
|
There was a problem hiding this comment.
Code Review
This pull request introduces a new script list_copy_backup_operations.py and its corresponding tests to list copy-backup operations on a destination Spanner instance. The feedback suggests a more idiomatic approach to deserialize the backup metadata by using CopyBackupMetadata.deserialize instead of accessing the underlying protobuf class.
| meta = spanner_admin_database_v1.CopyBackupMetadata.pb().FromString( | ||
| op.metadata.value | ||
| ) |
There was a problem hiding this comment.
Using spanner_admin_database_v1.CopyBackupMetadata.deserialize(op.metadata.value) is more idiomatic and cleaner than accessing the underlying protobuf class via .pb() and calling .FromString() when working with proto-plus messages.
| meta = spanner_admin_database_v1.CopyBackupMetadata.pb().FromString( | |
| op.metadata.value | |
| ) | |
| meta = spanner_admin_database_v1.CopyBackupMetadata.deserialize( | |
| op.metadata.value | |
| ) |
There was a problem hiding this comment.
Thanks! This comment refers to an earlier revision of this file; the code here has since been reworked in later commits, so this thread no longer applies to the current diff.
Deserializes operation metadata via proto-plus CopyBackupMetadata.deserialize and prints short backup and instance IDs without project identifiers.
Description
Monitoring copy-backup progress on a destination instance requires filtering
list_backup_operationsonCopyBackupMetadata, which previously had C# and Ruby tabs without a Python sample.Adds
spanner_list_copy_backup_operations.Checklist
Testing
Compliance & Style
spanner/, which the default repository owners cover.Post-Approval Actions