Repository navigation
Conversation
Production Spanner databases prevent accidental deletion by enabling enable_drop_protection via DatabaseAdminClient.update_database. Add a standalone spanner_update_database sample and test suite.
|
Here is the summary of changes. You are about to add 1 region tag.
This comment is generated by snippet-bot.
|
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a new Python script update_database.py that enables drop protection on a Google Cloud Spanner database using the DatabaseAdminClient. It also includes corresponding unit and integration tests in update_database_test.py to validate the update operation, CLI entry point, and error handling. I have no feedback to provide.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds
spanner_update_databaseenablingenable_drop_protectionon a Spanner database viaDatabaseAdminClient.update_database.Checklist
Testing
Compliance & Style
spanner/, which the default repository owners cover.Post-Approval Actions