Repository navigation
Conversation
CMEK backup guides protect Spanner backups with a customer-managed Cloud KMS key via CreateBackupEncryptionConfig. Add a standalone spanner_create_backup_with_encryption_key sample.
|
Here is the summary of changes. You are about to add 1 region tag.
This comment is generated by snippet-bot.
|
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a new script and corresponding tests to create a Cloud Spanner database backup encrypted with a Customer-Managed Encryption Key (CMEK) via Cloud KMS. The implementation includes robust error handling for common API exceptions and timeouts, as well as a command-line interface. I have no feedback to provide as the implementation and test coverage are complete and well-structured.
…on_key Problem: review of this sample identified correctness and robustness improvements in the sample and its tests. Solution: apply the accepted review suggestions and extend the tests to cover the updated behavior. Details are in the review thread replies. Files updated: - spanner/backups/tests/create_backup_with_encryption_key_test.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds
spanner_create_backup_with_encryption_keycreating a CMEK-encrypted Spanner backup.Checklist
Testing
Compliance & Style
spanner/, which the default repository owners cover.Post-Approval Actions