Skip to content

feat(spanner): Add multi-region CMEK CreateBackup sample - #14975

Open
iennae wants to merge 2 commits into
feat/spanner-copy-backupfrom
feat/spanner-create-backup-with-mr-cmek
Open

iennae wants to merge 2 commits into
feat/spanner-copy-backupfrom
feat/spanner-create-backup-with-mr-cmek

Conversation

@iennae

@iennae iennae commented Nov 18, 2026

Copy link
Copy Markdown
Contributor

Description

Adds spanner_create_backup_with_mr_cmek creating a multi-region CMEK-protected Spanner backup.

Note: Stacked on #14854 (feat/spanner-copy-backup) so this PR shows only this sample's diff. It will merge into main after #14854.

Checklist

Testing

  • I have tested this change on a live environment and verified it works as intended. Unit and live integration tests pass on Python 3.13.

Compliance & Style


Post-Approval Actions

  • Please merge this PR for me once it is approved

Multi-region CMEK backups configure regional Cloud KMS keys via CreateBackupEncryptionConfig.kms_key_names. Add a standalone spanner_create_backup_with_mr_cmek sample.
@iennae
iennae requested review from a team as code owners November 18, 2026 22:19
@snippet-bot

snippet-bot Bot commented Nov 18, 2026 •

Copy link
Copy Markdown

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label Bot added api: spanner Issues related to the Spanner API. samples Issues that are directly related to samples. labels Nov 18, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new Python script and corresponding tests to support creating multi-region Spanner backups protected by regional Customer-Managed Encryption Keys (CMEK). The implementation includes robust error handling and a command-line interface. I have no feedback to provide.

Problem: review of this sample identified correctness and robustness
improvements in the sample and its tests.

Solution: apply the accepted review suggestions and extend the tests to
cover the updated behavior. Details are in the review thread replies.

Files updated:
  - spanner/backups/tests/create_backup_with_mr_cmek_test.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: spanner Issues related to the Spanner API. samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant