Repository navigation
Conversation
Copying backups into multi-region instances encrypted with regional KMS keys uses CopyBackupEncryptionConfig.kms_key_names. Add a standalone spanner_copy_backup_with_mr_cmek sample.
|
Here is the summary of changes. You are about to add 1 region tag.
This comment is generated by snippet-bot.
|
There was a problem hiding this comment.
Code Review
This pull request introduces a new script and corresponding tests to copy a Google Cloud Spanner backup into a multi-region Customer-Managed Encryption Key (CMEK) destination backup. The implementation uses the Spanner DatabaseAdminClient to configure and execute the copy request, handling potential API errors and timeouts. The tests cover successful execution, error handling, CLI execution, and live integration testing. I have no feedback to provide as the implementation is complete and well-tested.
Problem: review of this sample identified correctness and robustness improvements in the sample and its tests. Solution: apply the accepted review suggestions and extend the tests to cover the updated behavior. Details are in the review thread replies. Files updated: - spanner/backups/tests/copy_backup_with_mr_cmek_test.py
Description
Adds
spanner_copy_backup_with_mr_cmekcopying a Spanner backup using multi-region Cloud KMS keys.Checklist
Testing
Compliance & Style
spanner/, which the default repository owners cover.Post-Approval Actions