Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request fixes several bugs across multiple Python sample files where string interpolation was intended but the f-prefix was missing from the print statements, causing literal curly braces to be printed instead of the variable values. It also corrects a minor typo ('release' to 'released') in one of the storage snippets. There are no review comments to address, and the changes look correct and complete.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Eleven
printcalls across five samples are plain strings containing{...}placeholders but nofprefix, so they print the template text instead of the values:talent/job_search_list_jobs.py(4 lines)Job name: {job.name}Job name: projects/.../jobs/123talent/job_search_histogram_search.py(4 lines)Job title: {job.title}dialogflow-cx/detect_intent_with_sentiment_analysis.pySentiment Score: {score}storage/samples/snippets/storage_set_temporary_hold.pyTemporary hold was set for #{blob_name}... set for my-blobstorage/samples/snippets/storage_release_temporary_hold.pyTemporary hold was release for #{blob_name}... released for my-blobThe storage samples used Ruby-style
#{...}interpolation, which Python doesn't support. I also fixed "was release" to "was released" in the same line.Only the
printlines change. Function signatures, return values and region tags are untouched, and no existing test asserts on these strings.Checklist
Testing
Compliance & Style
Post-Approval Actions