Repository navigation
feat(backend, http): add HTTP API for ADJ catalogs and WebSocket upgrade support - #676
Merged
Merged
Conversation
…utils file for serialize specific kinds of data
… more utils to serialize
JavierRibaldelRio
requested changes
Nov 14, 2026
JavierRibaldelRio
left a comment
Member
There was a problem hiding this comment.
In general the module is fine, however there are critical mistakes that must be solved.
May be it is better o include adj/http inside of model instead of adj as you commented in the workshop.
JavierRibaldelRio
requested changes
Nov 15, 2026
…g the implementation of Adj to http.rs
JavierRibaldelRio
requested changes
Nov 17, 2026
JavierRibaldelRio
left a comment
Member
There was a problem hiding this comment.
In general lines, review all documentation and its fine
cargo docs returns warnings as so cargo clippy --workspace -- -D warnings
Review al this and should be fine
JavierRibaldelRio
requested changes
Nov 17, 2026
JavierRibaldelRio
approved these changes
Nov 17, 2026
JavierRibaldelRio
left a comment
Member
There was a problem hiding this comment.
Correct this little things
GaziH
approved these changes
Nov 17, 2026
GaziH
left a comment
There was a problem hiding this comment.
Aside from what Javier mentioned, looks good!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Features
software-corehttpfeature:src/model/http/example/.Adjmethods to build the response catalogs.utilsmodule with serialization helpers.station/backend/adj/DataPackets/backend/adj/OrderPackets/backend/adj/ProtectionPackets/backend/ws, forwarding connections to a channel for future message handling.no-cache.main.rsfor manual testing.