Repository navigation
Extract admitted-error finalization from demo RC - #464
Open
ChristianPavilonis wants to merge 11 commits into
Open
ChristianPavilonis wants to merge 11 commits into
ChristianPavilonis wants to merge 11 commits into
Conversation
7 tasks done
aram356
added a commit
to IABTechLab/trusted-server
that referenced
this pull request
Nov 12, 2026
Collaborator
|
CREATOR: From the server-side identity plan (IABTechLab/trusted-server#1559, |
14 of 15 tasks
ChristianPavilonis
changed the base branch from
feature/pluggable-geo-providers
to
feature/kv-geoip
November 17, 2026 17:01
6 of 8 tasks
ChristianPavilonis
marked this pull request as ready for review
November 19, 2026 21:03
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
App::set_admitted_error_response_finalizer, an optional synchronous callback that runs once on each rendered admitted dispatch error, after the configured error renderer. It receives the request's existingGeoOutcomeand&mut Response, so an application can add the headers its middleware adds toOkresponses.89c279b59b75eb33b96eb30a35f78bf933762f34. It doesn't redesign response ownership or Geo policy, and adds no body carrier, transport, timer policy or production Geo provider.Changes
crates/edgezero-core/src/app.rsdispatch_admitted_with_geocalls it after rendering an admitted error and restores status and required headers. Three regression tests.docs/guide/native-geo.mdCloses
Closes #518
Refs #461. Integration RC #462 includes this PR at
96c21d731501370044f11ca5832e85701e79a421.Stack
Base is
feature/kv-geoip(#454), following the placement in #510: #439, then #510, then #454, then this PR, outside official stack membership. The PR's own diff uses only #439 APIs (GeoOutcome,dispatch_admitted_with_geo).The server-side identity plan (IABTechLab/trusted-server#1559, Part A and Part C) still says to drop #454's prototype commits and base this PR on #439's branch. That conflicts with #510 and is still open.
Head is
dfec0db36401831188ee15db8f17e40084b23827. The commits after96c21d73are merges of the parent branches. The PR's changed lines are identical to89c279b5.feature/kv-geoiphas since moved ahead by eight commits that aren't merged here yet, including2c41968b(Fastly and Cloudflare Geo throughctx.geo()) and7ef4766d(Axum Geo from the manifest).Test plan
dfec0db3: all 29 checks pass, including workspace tests, Axum, Fastly, Cloudflare and Spin tests and clippy,cargo fmtand docs formatting.cargo test -p edgezero-core --lib admitted_error_finalizeratdfec0db3: 3 passed.96c21d73): Core 1,174 default-parallel tests, Axum 488 and production-hosting 36 serial cases, scoped Clippy and formatting. These results are tied to that revision.Earlier local runs saw native parallel timing failures that nobody has classified. This PR doesn't relax their assertions or claim to fix them.
Not covered: ALB credential validation, cloud ingress, browser behavior and deployment.
Ready for review. It merges with the stack above, not directly into main.