Repository navigation
Add XML Documentation across the API, and add GainMultipleGems as an Ability Class - #343
Conversation
**Comment out unusued duplicate field**
Considering if the custom costs ID system can be deprecated, but it may have a use as a way of providing custom cost adjustments on CardModInfos
… not using it except in very specific cases
…verse key-value pair of currentSacrificedCardInfos, add XML
… two gems" sigils floating about
Chaosyr
left a comment
There was a problem hiding this comment.
If its of use, the following contains common XML tags that can be used and how to use them. https://learn.microsoft.com/en-us/dotnet/csharp/language-reference/xmldoc/recommended-tags
This PR is good once the two items mentioned are fixed across the module ^^
Add some missing XML and fix incorrect XML in AbilityExtensions
whoever added so many near-identical rulebook redirect methods should be shot 57 times (it was me, i should be shot 57 times)
Chaosyr
left a comment
There was a problem hiding this comment.
Outside of what I mentioned in dms this looks good ^^
|
|
||
| [HarmonyPostfix, HarmonyPatch(typeof(ResourcesManager), nameof(ResourcesManager.ForceGemsUpdate))] | ||
| private static void ForceOpponentGemsUpdate() => Singleton<OpponentGemsManager>.Instance?.ForceGemsUpdate(); | ||
| private static void ForceOpponentGemsUpdate(ResourcesManager __instance) { |
There was a problem hiding this comment.
should the change here be something put in the Changelog?
There was a problem hiding this comment.
This is part of the GainMultipleGems class's functionality, so I don't think it needs to be specifically mentioned; people will assume that the changes have occurred to make the new class work properly.
|
|
||
| GainGemTriple[] components2 = slot.Card.GetComponents<GainGemTriple>(); | ||
| for (int i = 0; i < components2.Length; i++) | ||
| GainMultipleGems[] components2 = slot.Card.GetComponents<GainMultipleGems>(); |
There was a problem hiding this comment.
Should this change be something we note in the Changelog?
There was a problem hiding this comment.
This is part of the GainMultipleGems class's functionality, so I don't think it needs to be specifically mentioned; people will assume that the changes have occurred to make the new class work properly.
941c0b8
into
InscryptionModding:Update-Installation-Guides-and-Documentation-and-Bug-Fixes
Adds all missing XML in the API.
Also adds GainMultipleGems, an ability subclass that allows for modders to create sigils that provide multiple gem colours instead of just one or all three.