Repository navigation
fix: stop sending OPENAI_ORG_ID / OPENAI_PROJECT_ID to Interfaze - #23
Conversation
|
@Abhinavexist friendly bump: this keeps OPENAI_ORG_ID / OPENAI_PROJECT_ID from the environment off requests to api.interfaze.ai (explicit organization= / project= still go through). It merges cleanly with main and the workflow only needs maintainer approval to run; the same fix for the JS SDK is in InterfazeAI/interfaze-js#17. Happy to adjust anything if the approach doesn't fit. |
|
Hi @Abhishek-B-R, Looks good. Resetting organization/project after construction makes sense here, since openai-python treats None as "not passed" and falls back to the env. One gap worth knowing about: Nothing in the SDK calls with_options itself, so I'm fine |
|
@Abhinavexist good catch, agreed: |
|
@Abhinavexist the note you asked for is in 76f6660: the comment above |
|
@Abhinavexist friendly bump: the with_options() / copy() caveat you raised is documented in 76f6660, the branch has no conflicts with main, and the one workflow just needs approval to run. If you'd prefer that gap handled in code rather than as a note, I can take that on here. |
|
LGTM @Abhishek-B-R, thanks for the change :) |
the openai client reads OPENAI_ORG_ID and OPENAI_PROJECT_ID from the environment and puts them on every request as OpenAI-Organization / OpenAI-Project. since Interfaze() is built on that client, anyone who also has openai configured on their machine sends their openai org and project ids to api.interfaze.ai.
repro: set OPENAI_ORG_ID=org-secret, call Interfaze(api_key=...).chat.completions.create(...), and the request carries
openai-organization: org-secret.this resets both to whatever was passed explicitly after the client is built, for sync and async. passing organization= / project= yourself still works.
tests: one that sets both env vars and checks neither header goes out (sync + async, fails on main), and one that checks explicit values still go through. pytest (140 passed, coverage gate ok), ruff and mypy --strict all pass.
same fix for the js SDK is in InterfazeAI/interfaze-js#17. OPENAI_CUSTOM_HEADERS gets merged in the same way here and can carry things like a gateway key; left it out to keep this small, happy to add it if you want it handled.