Skip to content

fix: epsilon and gamma calculations in KinematicsFactory - #1580

Merged
c-dilks merged 1 commit into
developmentfrom
fix-kinematicsfactory
Nov 12, 2026
Merged

c-dilks merged 1 commit into
developmentfrom
fix-kinematicsfactory

Conversation

@c-dilks

@c-dilks c-dilks commented Nov 11, 2026

Copy link
Copy Markdown
Member

No one uses this, as far as I can tell, but might as well fix it anyway. This is a breaking change.

  • getEpsilon is wrong, rather it almost returns $\gamma$
  • the denominator of the $\gamma$ calculation should be $Q$, not $Q^2$
  • the correct getEpsilon also needs an energy parameter (to calculate $y$)

@baltzell
baltzell force-pushed the fix-kinematicsfactory branch from cef9fd4 to d095c03 Compare November 12, 2026 19:13
@c-dilks
c-dilks enabled auto-merge (squash) November 12, 2026 21:39
No one uses this, as far as I can tell, but might as well fix it anyway. This is a breaking change.

- `getEpsilon` is wrong, rather it _almost_ returns $\gamma$
- the denominator of the $\gamma$ calculation should be $Q$, not $Q^2$
- the correct `getEpsilon` also needs an energy parameter (to calculate $y$)
@c-dilks
c-dilks force-pushed the fix-kinematicsfactory branch from d095c03 to c235b94 Compare November 12, 2026 21:39
@c-dilks
c-dilks merged commit ddb855f into development Nov 12, 2026
25 checks passed
@c-dilks
c-dilks deleted the fix-kinematicsfactory branch November 12, 2026 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants