Repository navigation
Conversation
The processing and reference lines features exposed their public names through index modules that re-exported other files, and the io directory had an index that mixed the reader registry with a re-export of io.ts. Callers now import from the files that define each name, which matches the project rule against index and barrel modules. The feature boundary in eslint.config.js lists each feature's public modules instead of allowing only the index. The processing module that registers its config section at boot is now integration.ts, and the reader registry is io/readerRegistry.ts.
✅ Deploy Preview for volview-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The processing and reference lines features exposed their public names through
index.tsfiles that only re-exported other modules, andsrc/io/index.tsmixed the reader registry with a re-export ofio.ts. This conflicts with the project rule against index and barrel modules, and it makes a reader follow one extra hop to find where a name is defined.Callers now import from the defining files.
src/processing/index.tsbecomessrc/processing/integration.ts, which still registers the processing config section and the launch-load subscriber whenApp.vueimports it at boot.src/io/index.tsbecomessrc/io/readerRegistry.ts, and the helpers it re-exported are imported fromsrc/io/io.ts.src/referenceLines/index.tsis removed.The feature boundary in
eslint.config.jsno longer allows only the index. Each feature with a public surface lists its public modules: processing exposesintegration,storeandtypes, and reference lines exposesReferenceLines.vue,ReferenceLineSegments.vue,geometryandstore. Imports of any other module of a feature from outside it still fail lint. The pure-layer rules are unchanged apart from dropping the entry for the bare directory import, which no longer resolves.