Repository navigation
motion: probe start errors name only the G38 code that gets them - #4879
Merged
Merged
Conversation
The error for a probe already in the target state said "G38.2 or G38.3" and "G38.4 or G38.5", but only G38.2 and G38.4 get it. G38.3 and G38.5 skip the check, trip at once at the start point and set #5070 to 1. The message made users think the no-error variants abort too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the probe is already in the target state at the start of a probe move, motion reports "Probe is already tripped when starting G38.2 or G38.3 move" or "Probe is already clear when starting G38.4 or G38.5 move". Only G38.2 and G38.4 get these errors. G38.3 and G38.5 skip the check, trip at once at the start point and set
#5070to 1.The messages made users, me included, think the no-error variants abort too (#4874, #4868). This drops G38.3 and G38.5 from them.
Checked in a sim on master, which has the same check: G38.2 and G38.4 abort with the probe already in the target state; G38.3 and G38.5 end at the start point with
#5070= 1.