Repository navigation
docs: fix dark-mode horizontal list descriptions - #4882
Merged
Merged
Conversation
Asciidoctor renders horizontal description lists as tables, whose generic td rule sets near-black text. Override hdlist2 cells along with hdlist1 so descriptions remain legible in dark mode.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix unreadable descriptions in horizontal definition lists in dark mode.
Asciidoctor renders these lists as tables, and its generic table-cell rule leaves
td.hdlist2descriptions near-black. Add these cells to the existing light-text override used for.hdlist1terms.Test
I rendered an Asciidoctor horizontal-list fixture in headless Firefox before and after the change with the dark-mode rules enabled. Descriptions are now light and readable; labels and surrounding paragraphs are unchanged.
git diff --checkpasses.