Repository navigation
CI 테스트 실패 수정, macOS 없이도 릴리스 — 0.2.1 - #7
Merged
Merged
Conversation
Raise the release version to 0.2.0 (pyproject, RELEASE_VERSION, Inno Setup default, lockfile) so the v0.2.0 tag matches and installed 0.1.0.x builds are offered the update. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01A9NzuHPqp7Wrrs8zF7CMvh
….2.1 The v0.2.0 tag build was the first CI run that got runners, and 28 UI tests failed on Windows and Linux: the headless-display action sets PYVISTA_OFF_SCREEN=true, so QtInteractor created no interactor and plotter.iren was None. The viewer now always asks for an interactive one. With that fixed, the UI tests crashed in VTK render() under Xvfb/Mesa after about twenty windows: a closed window never released its OpenGL render window. MainWindow.closeEvent now calls viewer.shutdown(), which stops the animation timer and closes the plotter. Full suite with CI's environment: 183 passed. The macOS job was cancelled the moment it was created (no runner), and the release job needs every build job, so it was skipped. It now runs unless a build failed, and refuses to publish an empty release. Version 0.2.1 so the fixed commit gets a fresh tag instead of moving v0.2.0. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01A9NzuHPqp7Wrrs8zF7CMvh
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
배경
v0.2.0태그 빌드(#15)는 처음으로 러너를 배정받은 CI 실행이었는데, Release가 만들어지지 않았습니다.tests/test_ui.py28개 실패 —plotter.iren이 Nonerelease:needs: build라서 건너뜀수정
ModelViewer가QtInteractor(off_screen=False)사용 — CI의setup-headless-display-action이PYVISTA_OFF_SCREEN=true를 걸면 pyvistaqt가 인터랙터를 만들지 않아 선택이 깨졌습니다. 앱 뷰어는 항상 대화형이어야 합니다.viewer.shutdown()) — 1번을 고치자 Xvfb/Mesa 소프트웨어 OpenGL에서 창 20여 개째에render()가 segfault했습니다. 닫힌 창이 OpenGL 렌더 창을 놓아주지 않아서였습니다.release작업: 빌드가 실패하면 막고, 취소(macOS 러너 없음)만 있으면 나머지 플랫폼으로 진행. 설치 파일이 하나도 없으면 실패. 앱의 업데이트 창은 그 OS용 파일이 없으면 이미 "이 운영체제용 설치 파일이 릴리스에 없습니다"라고 알립니다.v0.2.0태그를 옮기지 않고 새 태그를 쓰기 위해.확인
PYVISTA_OFF_SCREEN=true xvfb-run): 전체 183 passed. 수정 전에는 같은 환경에서 CI와 같은iren오류가 재현됨ruff check,ruff format --check통과병합 후
v0.2.1태그를 이 PR의 병합 커밋에 푸시하면 Windows·Linux 설치 파일(그리고 macOS가 돌면 dmg)이 Release에 올라갑니다. macOS 러너가 왜 배정되지 않는지는 조직 Actions 설정(허용 러너·Billing)에서 확인이 필요합니다.Generated by Claude Code