Skip to content

접촉 저랭크 갱신 정밀도 개선, Windows·Linux가 있어야 릴리스 — 0.2.2 - #9

Merged
knoxxr merged 7 commits into
mainfrom
ccr-da6cba6f-qulklh
Nov 20, 2026
Merged

knoxxr merged 7 commits into
mainfrom
ccr-da6cba6f-qulklh

Conversation

@knoxxr

@knoxxr knoxxr commented Nov 20, 2026

Copy link
Copy Markdown
Collaborator

배경

v0.2.1 릴리스 실행(run #20)에서 두 가지 문제가 있었습니다.

  1. Windows 테스트 실패: test_contact_solver_reuses_the_factorization — 접촉 솔버 결과가 새 분해와 최대 변위의 1.3e-6만큼 달라 허용치 1e-6을 넘음(PR #7의 Windows 실행에서는 통과 → 경계선).
  2. 그런데도 Release가 만들어짐(Linux 파일만): macOS가 취소되고 Windows가 실패하면 needs.build.result가 failure가 아니라 cancelled로 나와 조건을 통과했습니다.

수정

1. Woodbury 갱신에 반복 개선 1회 (fem/contact.py)

겹침 이음에서 측정:

최대 변위 대비 오차
직접 분해 vs 다른 순서(COLAMD) 직접 분해 6.0e-10
Woodbury 갱신(기존) 8.3e-7 (cond(S) ≈ 8.5e5)
Woodbury + 반복 개선 1회 9.3e-10

갱신만으로는 cond(S)·eps가 한계라 같은 연산자로 잔차 보정을 한 번 더 합니다(역대입 1회 + 행렬·벡터 곱 1회). 코드 주석은 "반복 개선이 발산한다"고 했지만 이 경우 수렴했고, 혹시 보정이 해의 1e-3을 넘으면 버리고 기존 값을 씁니다. 테스트 허용치는 그대로입니다(여유 1.2배 → 1000배).

2. 릴리스 조건 (build.yml)

release 작업이 Windows .exe와 Linux .tar.gz가 둘 다 있어야 Release를 만듭니다(macOS는 러너가 없어 선택).

3. 버전 0.2.2, CLAUDE.md 갱신

확인

  • CI와 같은 환경(PYVISTA_OFF_SCREEN=true xvfb-run): 183 passed
  • ruff check, ruff format --check 통과

병합 후

main에서 Run workflow → v0.2.2 Release(Windows + Linux). 이미 나간 v0.2.1 Release(Linux 파일만)는 0.2.2가 최신이 되면 앱 업데이트에서 더 이상 쓰이지 않습니다.


Generated by Claude Code

Raise the release version to 0.2.0 (pyproject, RELEASE_VERSION, Inno Setup
default, lockfile) so the v0.2.0 tag matches and installed 0.1.0.x builds
are offered the update.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01A9NzuHPqp7Wrrs8zF7CMvh
….2.1

The v0.2.0 tag build was the first CI run that got runners, and 28 UI tests
failed on Windows and Linux: the headless-display action sets
PYVISTA_OFF_SCREEN=true, so QtInteractor created no interactor and
plotter.iren was None. The viewer now always asks for an interactive one.

With that fixed, the UI tests crashed in VTK render() under Xvfb/Mesa after
about twenty windows: a closed window never released its OpenGL render
window. MainWindow.closeEvent now calls viewer.shutdown(), which stops the
animation timer and closes the plotter. Full suite with CI's environment:
183 passed.

The macOS job was cancelled the moment it was created (no runner), and the
release job needs every build job, so it was skipped. It now runs unless a
build failed, and refuses to publish an empty release.

Version 0.2.1 so the fixed commit gets a fresh tag instead of moving v0.2.0.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01A9NzuHPqp7Wrrs8zF7CMvh
A manual run of the build workflow on main now builds as usual and the
release job creates the v<pyproject version> tag and the GitHub Release at
that commit (it refuses when the tag already exists). Tag pushes work as
before.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01A9NzuHPqp7Wrrs8zF7CMvh
…ux; 0.2.2

Windows CI failed test_contact_solver_reuses_the_factorization: the solver's
answer differed from a fresh factorization by 1.3e-6 of the peak displacement
(limit 1e-6). The Woodbury update alone is only as accurate as cond(S)*eps:
on the lap joint cond(S) ~ 8.5e5 left 8.3e-7, while two direct solves with
different orderings agree to 6e-10. One step of iterative refinement with the
same operator brings it to 9.3e-10; the step is kept only when it is a small
correction.

The v0.2.1 run still published a Release although the Windows build failed:
with one leg failed and another (macOS, no runner) cancelled,
needs.build.result reads 'cancelled'. The release job now also requires the
Windows installer and the Linux archive to be present.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01A9NzuHPqp7Wrrs8zF7CMvh
@knoxxr
knoxxr merged commit e78b099 into main Nov 20, 2026
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants