You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
fix(cuda.core): point the stream protocol warning at Device.create_stream - #3522
No actionable comments were generated in the recent review.
Summary
Summary by CodeRabbit
Bug Fixes
Updated the deprecation warning for foreign stream objects to recommend Device.create_stream(obj) instead of Stream(obj). This clarifies the suggested conversion API when a foreign stream is passed through the stream protocol; stream conversion behavior is unchanged.
The __cuda_stream__ deprecation warning now directs callers to Device.create_stream(obj) instead of Stream(obj). The test expectation uses the updated guidance.
The deprecation warning and its test expectation now name Device.create_stream(obj).
Assessment against linked issues
Objective
Addressed
Explanation
Update the __cuda_stream__ deprecation warning to name the working conversion API, Device.create_stream(obj) [#3505]
✅
Suggested reviewers:andy-jost
Change: Bug fix · Severity of issue fixed: Low
Merge Risk: Minimal · up to 6db8e
This updates a deprecation warning so it recommends the working call, device.create_stream(obj), instead of Stream(obj), which raises. The change is limited to message text and its test, so the merge risk is minimal. The failing PR metadata check should be fixed by adding an assignee, labels, and a milestone.
Security architecture risk: Minimal · up to b30df
The change corrects migration advice without describing any change to stream creation, permissions, ownership, or runtime behavior.
Finishing Touches
Fix failing CI checks
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Reviewing files that changed from the base of the PR and between b30dfb9 and 6db8e6e.
Files selected for processing: 2
cuda_core/cuda/core/_stream.pyx
cuda_core/tests/test_launcher.py
Files skipped from review as they are similar to previous changes: 2
cuda_core/cuda/core/_stream.pyx
cuda_core/tests/test_launcher.py
Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 11 remain after this review.
Reviewing files that changed from the base of the PR and between 7de038b and b30dfb9.
Files selected for processing: 2
cuda_core/cuda/core/_stream.pyx
cuda_core/tests/test_launcher.py
Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 11 remain after this review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cuda.coreEverything related to the cuda.core module
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
closes #3505
the deprecation warning told users to convert with
Stream(obj), butStream.__init__always raises, so it points atdevice.create_stream(obj)nowChecklist