Repository navigation
Conversation
dweindl
force-pushed
the
v2_unique_ids
branch
from
November 17, 2026 10:27
a58047c to
0b4778b
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #606 +/- ##
==========================================
+ Coverage 80.18% 80.33% +0.15%
==========================================
Files 70 70
Lines 8442 8519 +77
Branches 1544 1562 +18
==========================================
+ Hits 6769 6844 +75
- Misses 1182 1187 +5
+ Partials 491 488 -3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
dweindl
force-pushed
the
v2_unique_ids
branch
5 times, most recently
from
November 17, 2026 21:43
d79d493 to
daecbff
Compare
dweindl
marked this pull request as ready for review
November 17, 2026 21:51
Add `CheckGloballyUniqueIds`. Condition, experiment, observable, model and placeholder IDs, mapping table `petabEntityId`s and parameter IDs must be defined only once and must not be model entity IDs. Parameter table entries for model entities or mapped entities are references, not definitions. A mapping table row with an empty `modelEntityId` is for an entity that is not in any model, so its `petabEntityId` must not be a model entity. The task replaces `CheckObservablesDoNotShadowModelEntities` in the default validation tasks, which is deprecated, and the overlapping checks in `CheckMappingTable`. For multi-model problems, the task runs on the full problem, so table entries are compared across all models. IDs from the condition, experiment, observable and parameter tables only clash with the entities of the models they are used with; IDs not used with any model don't clash with model entities. Mapping table IDs and model IDs are compared with all models. Each clash is reported once. Add `CheckPlaceholdersOnlyUsedInOwnObservable`: placeholders must not be used in other observables, the condition table or measurement overrides, and noise placeholders must not be used in the observable formula. Closes PEtab-dev#555. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
dweindl
force-pushed
the
v2_unique_ids
branch
from
November 18, 2026 12:58
daecbff to
e83f64a
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
CheckGloballyUniqueIdsto the default v2 validation tasks. It reports IDs that are defined more than once or coincide with a model entity, together with the places where they are defined, e.g.`a` (observable placeholder of `o1`, observable placeholder of `o2`).Definitions are condition, experiment, observable, model and placeholder IDs, mapping table
petabEntityIds (except identity mappings and rows with an emptymodelEntityId), and parameter table IDs that aren't mapped entities. A parameter table entry for a model entity refers to that entity and is no clash. A mapping table row with an emptymodelEntityIdis for an entity that is not in any model, so itspetabEntityIdmust not be a model entity. Identity mappings (petabEntityId == modelEntityId), which can also serve as annotations, may refer to model entities. Duplicates within a single table are still reported byCheckUniquePrimaryKeys.Adds
CheckPlaceholdersOnlyUsedInOwnObservable: placeholders must not be used in other observables, condition targets or target values, or measurement overrides, and noise placeholders must not be used in the observable formula.The new tasks replace
CheckObservablesDoNotShadowModelEntities(now deprecated) in the default validation tasks, and the checks inCheckMappingTableforpetabEntityIds that are defined elsewhere or referenced in the model.For multi-model problems, both tasks run on the full problem, so table entries are compared across all models. IDs from the condition, experiment, observable and parameter tables only clash with the entities of the models they are used with (based on
Problem.split_by_model). IDs not used with any model don't clash with model entities. Mapping table IDs and model IDs are compared with the entities of all models.Closes #555.
🤖 Generated with Claude Code