Repository navigation
Reject NaN and complex infinity in PEtab math output - #613
Open
ChenYueqi2024 wants to merge 2 commits into
Open
ChenYueqi2024 wants to merge 2 commits into
ChenYueqi2024 wants to merge 2 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #549.
petab_math_str(sp.nan)currently emitsnan, and printingsympify_petab("x / 0")emitszoo*x. Neither can be read back as valid PEtab math. Add printer handlers that raise a descriptive ValueError for NaN and complex infinity, including when they occur inside larger expressions. Real positive/negative infinity keep their existing representation.Tests exercise both the convenience function and PetabStrPrinter directly, including multiplication, unevaluated addition and piecewise branches. All 12 rejection cases fail before the fix; two infinity round-trip controls pass before and after. The documented exception and changelog are included.
Validation on Windows / Python 3.12:
Implemented and validated with OpenAI Codex assistance. Ready for review.