Repository navigation
Explain unresolved condition parameter references - #615
Open
ChenYueqi2024 wants to merge 2 commits into
Open
ChenYueqi2024 wants to merge 2 commits into
ChenYueqi2024 wants to merge 2 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #519.
When a condition override refers to an SBML parameter whose initial assignment cannot be reduced to a numeric value, the mapper may fall back to indexing a nonexistent parameter-table row. Check for that row first and raise a descriptive ValueError naming both the referenced parameter and the override target. Valid references still use the existing model or parameter-table resolution.
The regression test exercises the public mapping API with and without a parameter scale column. Both cases raise a raw KeyError before the fix and report the unresolved reference afterward.
Validation on Windows with Python 3.12: 44 mapping, lint, and calculation tests pass. All applicable pre-commit hooks and
git diff --checkpass.Implemented and validated with OpenAI Codex assistance. Ready for review.