Repository navigation
Require compartments for concrete PySB species - #616
Open
ChenYueqi2024 wants to merge 2 commits into
Open
ChenYueqi2024 wants to merge 2 commits into
ChenYueqi2024 wants to merge 2 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #593.
PySBModel.is_state_variableaccepted a fully specified set of sites even when the species lacked a compartment in a compartmental model. Use PySB's complex-level concreteness check. A complex can specify a shared compartment or a compartment for each monomer. The existing site multiplicity and bond checks still apply.Regression tests cover omitted and explicit compartments for single monomers and complexes, including partially specified complexes and models without compartments. The two affected tests fail on the original implementation. All 37 PySB model and v1 lint tests pass on Windows with Python 3.12, as do the applicable pre-commit hooks.
Implemented and tested with OpenAI Codex assistance. Ready for review.