Repository navigation
Skip observable flattening without timepoint-specific overrides - #617
Open
ChenYueqi2024 wants to merge 2 commits into
Open
ChenYueqi2024 wants to merge 2 commits into
ChenYueqi2024 wants to merge 2 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #314.
Flatten only if an observable's parameter overrides vary among rows for the same simulation and preequilibration conditions. This preserves the measurement, observable, and visualization tables when there is nothing to flatten. Count rows with missing preequilibration the same way in both grouping operations, so a mixture of preequilibrated and ordinary rows does not create a false positive.
Unflattening accepts already-original observable IDs and continues to decode synthetic IDs written by older runs. Tests now cover ordinary measurements, condition-only overrides, and results from older runs. Both new no-op cases fail before the fix. All 61 tests across the selected v1 problem, lint, and parameter-mapping modules and all applicable pre-commit hooks pass on Windows with Python 3.12.
Implemented and tested with OpenAI Codex assistance. Ready for review.