Skip to content

Skip observable flattening without timepoint-specific overrides - #617

Open
ChenYueqi2024 wants to merge 2 commits into
PEtab-dev:mainfrom
ChenYueqi2024:fix/noop-flatten-without-overrides-314
Open

ChenYueqi2024 wants to merge 2 commits into
PEtab-dev:mainfrom
ChenYueqi2024:fix/noop-flatten-without-overrides-314

Conversation

@ChenYueqi2024

Copy link
Copy Markdown

Fixes #314.

Flatten only if an observable's parameter overrides vary among rows for the same simulation and preequilibration conditions. This preserves the measurement, observable, and visualization tables when there is nothing to flatten. Count rows with missing preequilibration the same way in both grouping operations, so a mixture of preequilibrated and ordinary rows does not create a false positive.

Unflattening accepts already-original observable IDs and continues to decode synthetic IDs written by older runs. Tests now cover ordinary measurements, condition-only overrides, and results from older runs. Both new no-op cases fail before the fix. All 61 tests across the selected v1 problem, lint, and parameter-mapping modules and all applicable pre-commit hooks pass on Windows with Python 3.12.

Implemented and tested with OpenAI Codex assistance. Ready for review.

@ChenYueqi2024
ChenYueqi2024 requested a review from a team as a code owner November 19, 2026 13:19
Copilot AI balanced review requested due to automatic review settings November 19, 2026 13:19

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

flatten_timepoint_specific_output_overrides should not do anything if there are no timepoint-specific output parameters

2 participants