Skip to content

Replace stale model files when converting to PEtab v2 - #618

Open
ChenYueqi2024 wants to merge 2 commits into
PEtab-dev:mainfrom
ChenYueqi2024:fix/refresh-converted-model-566
Open

ChenYueqi2024 wants to merge 2 commits into
PEtab-dev:mainfrom
ChenYueqi2024:fix/refresh-converted-model-566

Conversation

@ChenYueqi2024

Copy link
Copy Markdown

Fixes #566.

A second v1-to-v2 conversion into an existing output directory can keep the previous model while writing the current tables. Copy the current input model whenever it differs from the destination file. Keep the same-file guard and leave the existing experiment-table checks in place.

The regression test converts two input problems into the same directory. The second conversion now loads the new model's parameter value, 0.7, instead of the previous value, 0.5.

Validation on Windows with Python 3.12: 62 local conversion tests pass and two optional benchmark tests are skipped. The separate remote-example test encountered a TLS connection error while downloading its input. Applicable pre-commit hooks pass.

Implemented and tested with OpenAI Codex assistance. Ready for review.

@ChenYueqi2024
ChenYueqi2024 requested a review from a team as a code owner November 19, 2026 13:19
Copilot AI balanced review requested due to automatic review settings November 19, 2026 13:19

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

petab_files_1to2 keeps a stale model file when converting into a non-empty output directory

2 participants