Repository navigation
Report estimated model parameters missing from every mapping - #619
Open
ChenYueqi2024 wants to merge 2 commits into
Open
ChenYueqi2024 wants to merge 2 commits into
ChenYueqi2024 wants to merge 2 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #522.
The v1 mapper can omit a model parameter whose initial assignment depends on another symbol, even when the parameter table marks it for estimation. After computing the mappings, raise a ValueError if such a parameter would be absent from every simulation and preequilibration mapping. A valid condition or output override can still supply the parameter.
Regression tests exercise the silent omission and a working condition override in both single-threaded and multi-threaded mapping. The omission cases fail on the original implementation. All 46 v1 mapping, lint, and calculation tests and all applicable pre-commit hooks pass on Windows with Python 3.12.
Implemented and tested with OpenAI Codex assistance. Ready for review.