Skip to content

Report estimated model parameters missing from every mapping - #619

Open
ChenYueqi2024 wants to merge 2 commits into
PEtab-dev:mainfrom
ChenYueqi2024:fix/report-unmapped-estimated-parameters-522
Open

ChenYueqi2024 wants to merge 2 commits into
PEtab-dev:mainfrom
ChenYueqi2024:fix/report-unmapped-estimated-parameters-522

Conversation

@ChenYueqi2024

Copy link
Copy Markdown

Fixes #522.

The v1 mapper can omit a model parameter whose initial assignment depends on another symbol, even when the parameter table marks it for estimation. After computing the mappings, raise a ValueError if such a parameter would be absent from every simulation and preequilibration mapping. A valid condition or output override can still supply the parameter.

Regression tests exercise the silent omission and a working condition override in both single-threaded and multi-threaded mapping. The omission cases fail on the original implementation. All 46 v1 mapping, lint, and calculation tests and all applicable pre-commit hooks pass on Windows with Python 3.12.

Implemented and tested with OpenAI Codex assistance. Ready for review.

@ChenYueqi2024
ChenYueqi2024 requested a review from a team as a code owner November 19, 2026 13:19
Copilot AI balanced review requested due to automatic review settings November 19, 2026 13:19

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

An estimated parameter is silently dropped from the simulation mapping when the model cannot give it a value

2 participants