Skip to content

Accept the RavenDB index search engine ADR and align it with the shipped behavior - #6138

Merged
danielmarbach merged 2 commits into
masterfrom
ravendb-index-adr-accepted
Nov 16, 2026
Merged

danielmarbach merged 2 commits into
masterfrom
ravendb-index-adr-accepted

Conversation

@mauroservienti

@mauroservienti mauroservienti commented Nov 16, 2026 •

Copy link
Copy Markdown
Member

Follow-up to #6043. The stack the ADR records is merged and shipped in 6.22.2, so the status moves from Proposed to Accepted. Since the ADR was written, #6035 and #6036 changed behavior it describes. This aligns the ADR with the code on master.

Changes

…ped behavior

The stack the ADR records is merged and shipped in 6.22.2. Since the ADR
was written, #6035 and #6036 changed behavior it describes:

- Rule 3 replaces Corax set on the index, so such an index no longer
  stays on Corax across definition changes; rules 1 and 2 warn about a
  non-Lucene engine.
- A locked index with a changed definition stops the start-up in either
  lock mode, not only LockedError. #6107 makes maintenance mode skip the
  database setup so the operator can unlock the index.

Also links the fixed bugs (#6094, #6095), the backports, the operator
guidance in docs.particular.net (#8639, #8645), and records the rejected
"refuse to start on Corax" alternative from #6035.
Auto indexes follow the database setting and have no search engine of
their own, so neither the rules in the ADR nor the per-index migration
can move them to Lucene. #5953, #6099, and #6100 replaced the remaining
dynamic queries with static indexes, and #6120 makes a dynamic query
throw in tests. The ADR now records the decision, its consequences for
existing auto indexes and swallowed exceptions, and the #6115 teardown
check as the alternative. docs/testing.md tells developers what to do
when a query throws.
@danielmarbach
danielmarbach enabled auto-merge (squash) November 16, 2026 14:28
@danielmarbach
danielmarbach merged commit 5ee1d78 into master Nov 16, 2026
36 checks passed
@danielmarbach
danielmarbach deleted the ravendb-index-adr-accepted branch November 16, 2026 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants