Repository navigation
Accept the RavenDB index search engine ADR and align it with the shipped behavior - #6138
Merged
Merged
Conversation
…ped behavior The stack the ADR records is merged and shipped in 6.22.2. Since the ADR was written, #6035 and #6036 changed behavior it describes: - Rule 3 replaces Corax set on the index, so such an index no longer stays on Corax across definition changes; rules 1 and 2 warn about a non-Lucene engine. - A locked index with a changed definition stops the start-up in either lock mode, not only LockedError. #6107 makes maintenance mode skip the database setup so the operator can unlock the index. Also links the fixed bugs (#6094, #6095), the backports, the operator guidance in docs.particular.net (#8639, #8645), and records the rejected "refuse to start on Corax" alternative from #6035.
danielmarbach
approved these changes
Nov 16, 2026
Auto indexes follow the database setting and have no search engine of their own, so neither the rules in the ADR nor the per-index migration can move them to Lucene. #5953, #6099, and #6100 replaced the remaining dynamic queries with static indexes, and #6120 makes a dynamic query throw in tests. The ADR now records the decision, its consequences for existing auto indexes and swallowed exceptions, and the #6115 teardown check as the alternative. docs/testing.md tells developers what to do when a query throws.
danielmarbach
approved these changes
Nov 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #6043. The stack the ADR records is merged and shipped in 6.22.2, so the status moves from Proposed to Accepted. Since the ADR was written, #6035 and #6036 changed behavior it describes. This aligns the ADR with the code on
master.Changes
LockedError.docs/README.md: the ADR's index entry mentions locked indexes and static indexes.docs/testing.md: says that the RavenDB test servers make a dynamic query throw, and to query through a static index instead.