Repository navigation
ADR: Record how the namespace of a RavenDB index decides its database - #6147
Open
mauroservienti wants to merge 1 commit into
Open
mauroservienti wants to merge 1 commit into
mauroservienti wants to merge 1 commit into
Conversation
danielmarbach
approved these changes
Nov 17, 2026
Contributor
|
Can we wait for the agent.md changes to go in? I just rebased that one |
Contributor
|
The agent.md changes are in |
#6099 fixed #6123 by deploying the index classes in the Throughput.Indexes namespace to the throughput database and all others to the error database. The ADR records that this is a weak, unenforced convention, the risks and their mitigations, how to add a new index, and the alternatives, including a per-database marker as the point of leverage.
danielmarbach
force-pushed
the
ravendb-index-database-placement-adr
branch
from
November 17, 2026 08:00
b0a5571 to
841d5de
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an ADR for how the error persister decides which database a RavenDB index is deployed to. #6099 fixed #6123 by deploying the index classes in the
ServiceControl.Persistence.RavenDB.Throughput.Indexesnamespace to the throughput database and all others to the error database. That check is a naming convention the compiler does not enforce, and it fails silently, so the rationale, the risks, and the rules for adding an index need a record that outlives the pull request.The ADR
EndpointIndexended up in the error database from 5.4.0 without anyone noticing.DatabaseSetup, the target database parameter ofIndexDeployment.CreateIndexesAsync, and the deletion of the old copy from the error database, including locked copies.Query<T, TIndex>and Make RavenDB throw on queries that would create an auto index in tests #6120EndpointIndex's namespace moves the check for every throughput indexdocs/README.mdlinks the ADR under Decisions and rationale.