Repository navigation
skill: remove three stale design documents from docs/core - #96
Merged
Merged
Conversation
rearchitecture_2_0.md, rearchitecture_2_0_requirements.md and part_assembly_development_plan.md (1,944 lines) describe the 2.0 Python architecture and a development plan, and what they say is no longer true: the first says the evaluator still calls cadquery and the OCP-native migration is unfinished (the engine is C++ and needs neither), the third calls connectors and the mate solver future work (both are implemented) and lists multi-body parts as a goal (a Part holds one solid). Nothing linked to the first two but each other; the third was one line of docs/core/README.md, whose 'Product semantics roadmap' entry goes too. They stay in the git history. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes
rearchitecture_2_0.md,rearchitecture_2_0_requirements.mdandpart_assembly_development_plan.mdfromdocs/skill/references/docs/core/(1,944 lines an agent would read as documentation), and the one index entry for the last (Product semantics roadmapincore/README.md). They stay in the git history.What they say is no longer true:
rearchitecture_2_0.md: "the OCP-native evaluator migration is unfinished, many implementations still callcadquery". The engine is C++ and needs neither.part_assembly_development_plan.md: connectors and the mate solver are "future work, out of scope" (both are implemented) and multi-body parts are a goal (aPartholds one solid).rearchitecture_2_0_requirements.md: the acceptance document of the first; the two linked only to each other.Checked:
skillbuild.py --check(517 → 514 files),test_skill_lint,test_skill_build,test_auto_docs_gen,test_drawing_skill_integration: 73 passed against the 2.3.0 native module.🤖 Generated with Claude Code