Repository navigation
usb.core: the ESP32-P4 needs no full_speed=True behind a high-speed hub - #746
Merged
Merged
Conversation
The P4's firmware now builds the registry's USB host library with split transactions, as the S31's does, so keyboards and MIDI controllers work behind a high-speed hub. start()'s docstring, the support table, the USB guide and the WIFI6 DEV-KIT board config say so, and keep full_speed=True for P4 firmware on ESP-IDF's own host library. Checked on the DEV-KIT's onboard hub: an Arturia KeyStep Pro at full speed and a flash drive at high speed together, with no full_speed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With PyDevices/omnipython-builds#624 the ESP32-P4's firmware builds the component registry's USB host library with split transactions, the same as the ESP32-S31's, so a keyboard, MIDI controller or other full-speed device works behind a high-speed hub without
usb.core.start(full_speed=True). This updates what told P4 users otherwise:usb.core.start()'s docstring and the module comment, the limits row indocs/reference/usb-support.md, the hub paragraph in the USB guide, and the WIFI6 DEV-KIT board config's note on its onboard hub.full_speed=Truestays documented for P4 firmware built on ESP-IDF's own host library, and the DEV-KIT's once-per-power-up speed rule is unchanged.Checked on a Waveshare ESP32-P4-WIFI6-DEV-KIT running #624's image, on its onboard CH334F hub at high speed: an Arturia KeyStep Pro enumerated at full speed and answered 50 of 50 MIDI identity requests while a PNY flash drive at high speed read at 12.8 MB/s (12.9 MB/s on ESP-IDF's own library) and wrote and read back a 1 MiB file with a matching SHA-256. After a hard reset,
full_speed=Truestill brought both up at full speed.tests/test_usb_core_speed_guard.pypasses. Merge after #624.