Repository navigation
fix(cloud): use the resolved project for live portfolio state - #750
Open
pcbeingused333 wants to merge 1 commit into
Open
pcbeingused333 wants to merge 1 commit into
pcbeingused333 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #743
Cloud live deploy passed the original CLI argument to the portfolio lookup even when the cloud project had resolved successfully. A project ID or a name changed during a push therefore pointed the lookup at the wrong directory. The local result reader could also select a result from a different project after comparing deployment times.
Both deployment modes now pass the local path returned during project resolution, including the path recorded by the push if it renamed the project. For a cloud-only lookup by ID or name, the CLI checks the matching local directory by cloud ID with a read-only config lookup. The result reader uses the most recent local deployment in that directory when it is newer than the cloud deployment.
The CLI regression test covers a cloud ID and a push-induced rename against a fake workspace. In both cases the cash offered must come from the resolved project even though another project's result file is newer.
This change was prepared with assistance from an AI coding tool.