Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes an issue where
fread()incorrectly parsed numbers enclosed in quotation marks ascharacterwhen leading or trailing whitespace was present inside the quotes (e.g." 123"or"123 "), whereas baseread.table(..., strip.white=TRUE)parses them asnumeric.Root Cause
During type detection and data reading in
src/fread.c,freadadvanced over the opening quote (ch++) directly onto whitespace without callingskip_white(). Because numeric parsers strictly require immediate signs or digits, they rejected the whitespace and defaulted the column type toCT_STRING.Adding
skip_white()after opening quotes and before closing quotes allowsfreadto skip inner whitespace around numbers, matching the behavior of unquoted numbers andread.table().Example
Checklist
inst/tests/tests.RrawNEWS.md