Skip to content

v5.1.0 Npm publish - #930

Merged
bourgeoa merged 146 commits into
mainfrom
npmPublish
Nov 16, 2026
Merged

bourgeoa merged 146 commits into
mainfrom
npmPublish

Conversation

@bourgeoa

Copy link
Copy Markdown
Contributor

No description provided.

jeswr and others added 30 commits September 29, 2026 23:47
Co-authored-by: SharonStrats <9412507+SharonStrats@users.noreply.github.com>
Co-authored-by: SharonStrats <9412507+SharonStrats@users.noreply.github.com>
github-actions Bot and others added 25 commits November 2, 2026 11:21
move pane menu item prepration to solid-ui
revert to sharing pane for release
fix the chat icon being too big
add showback option to support direct url
fix(acl): allow dragging Everyone directly from the sharing chooser
update solid-logic and pane-registry
add the default color from internal pane
Copilot AI balanced review requested due to automatic review settings November 16, 2026 15:20
@bourgeoa
bourgeoa merged commit f6a8ff5 into main Nov 16, 2026
9 checks passed

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The authorization change planner loses grant identity and combined subject constraints, potentially broadening access and making grant removals ambiguous.

11 open issues
What changed in this PR

Prepares solid-ui 5.1.0 for npm publication, adding reusable file-explorer and access-management interfaces alongside accessibility and widget improvements.

Changes:

  • Adds explorer composition, navigation events, resource headers, and action menus.
  • Introduces an access-control modal with grant drafts, target resolution, scoped saving, and error reporting.
  • Improves editor accessibility, form labels, deletion confirmations, and navigation icons, with supporting tests and documentation.
File Description
test/​unit/​widgets/​forms/​autocomplete/​__snapshots__/​autocomplete.test.ts.snap Updates remove-control accessibility snapshots.
test/​unit/​widgets/​buttons/​iconLink.test.ts Tests Lucide navigation links and custom icons.
test/​unit/​widgets/​buttons.test.ts Tests confirmation placement and focus handling.
test/​unit/​index.test.ts Updates expected public exports.
test/​unit/​file-explorer/​relevant-panes.test.ts Tests pane filtering and preference selection.
test/​unit/​file-explorer/​pane-menu-items.test.ts Tests pane actions and icon resolution.
test/​unit/​codeEditor.test.js Tests editor accessibility and read-only configuration.
test/​unit/​acl/​add-agent-buttons.test.ts Tests public-access dragging and clicking.
test/​components/​error-state.test.ts Tests error rendering and close events.
test/​components/​compose-explorer.test.ts Tests explorer composition and nested event ownership.
test/​components/​access-control-modal/​buildAccessChanges.test.ts Tests access-change ordering.
test/​components/​access-control-modal/​accessTargetResolver.test.ts Tests target resolution and trusted-app suggestions.
test/​components/​access-control-modal/​accessGrantDrafts.test.ts Tests grant identity and role aggregation.
src/​widgets/​forms/​autocomplete/​autocompletePicker.ts Handles missing autocomplete results.
src/​widgets/​buttons/​iconLinks.ts Uses Lucide icons for default navigation links.
src/​widgets/​buttons.ts Adds external confirmations and deletion focus handling.
src/​utils/​webIdUtils.ts Adds profile and owner-name lookup helpers.
src/​utils/​podUtils.ts Adds storage discovery and container helpers.
src/​types/​custom-elements.d.ts Adds element typings for new components.
src/​styles/​theme.css Extends shared color tokens.
src/​lib/​file-explorer/​relevant-panes.ts Selects relevant and preferred panes.
src/​lib/​file-explorer/​pane-menu-items.ts Builds pane menu actions.
src/​lib/​file-explorer/​index.ts Exports explorer utilities.
src/​lib/​file-explorer/​events.ts Defines explorer events and ownership checks.
src/​lib/​file-explorer/​context.ts Defines editor registration and explorer state.
src/​lib/​file-explorer/​compose-explorer.ts Composes headers and pane content.
src/​lib/​context/​noopContext.ts Adds a missing-provider error proxy.
src/​lib/​components/​traits/​FormControlTrait.ts Supports visually hidden labels.
src/​lib/​components/​form-control-component/​FormControlComponent.ts Exposes the hidden-label property.
src/​lib/​code-editor/​CodeEditor.ts Adds accessibility settings and Tab indentation.
src/​index.ts Exports the explorer helper API.
src/​components/​select/​Select.stories.ts Demonstrates hidden labels.
src/​components/​resource-actions-menu/​ResourceActionsMenu.ts Adds resource and pane actions.
src/​components/​resource-actions-menu/​ResourceActionsMenu.test.ts Tests action visibility and dispatch.
src/​components/​resource-actions-menu/​ResourceActionsMenu.styles.css Styles the action-menu trigger.
src/​components/​resource-actions-menu/​index.ts Exports the action-menu component.
src/​components/​resource-actions-menu/​DeleteResourceDialog.ts Adds a deletion confirmation dialog.
src/​components/​menu-item/​MenuItem.styles.css Normalizes slotted icon sizing.
src/​components/​input/​Input.ts Adds a left-icon slot.
src/​components/​input/​Input.styles.css Styles input icons and configurable borders.
src/​components/​input/​Input.stories.ts Demonstrates hidden input labels.
src/​components/​index.ts Registers the explorer provider early.
src/​components/​file-explorer-provider/​index.ts Exports the explorer provider.
src/​components/​file-explorer-provider/​FileExplorerProvider.ts Provides explorer and editor state.
src/​components/​file-explorer-header/​types.ts Defines header metadata types.
src/​components/​file-explorer-header/​index.ts Exports the explorer header.
src/​components/​file-explorer-header/​FileExplorerHeaderSummary.ts Renders resource details and navigation.
src/​components/​file-explorer-header/​FileExplorerHeaderSummary.styles.css Styles resource summaries and status badges.
src/​components/​file-explorer-header/​FileExplorerHeaderControls.ts Adds responsive editing and sharing controls.
src/​components/​file-explorer-header/​FileExplorerHeaderControls.styles.css Styles actions and unsaved-change indicators.
src/​components/​file-explorer-header/​FileExplorerHeader.ts Loads metadata and composes header components.
src/​components/​file-explorer-header/​FileExplorerHeader.styles.css Defines header layout.
src/​components/​error-state/​index.ts Exports the error-state component.
src/​components/​error-state/​ErrorState.ts Adds a reusable dismissible error alert.
src/​components/​error-state/​ErrorState.styles.css Styles error content and controls.
src/​components/​error-state/​ErrorState.stories.ts Demonstrates error and recovery presentations.
src/​components/​combobox/​Combobox.ts Applies disabled state and opens on click.
src/​components/​combobox/​Combobox.styles.css Adds focus indicators and configurable borders.
src/​components/​combobox/​Combobox.stories.ts Demonstrates hidden combobox labels.
src/​components/​access-control-modal/​types.ts Defines grant, event, and error types.
src/​components/​access-control-modal/​index.ts Exports the access-control modal.
src/​components/​access-control-modal/​helpers.ts Adds origin validation and deduplication helpers.
src/​components/​access-control-modal/​buildAccessChanges.ts Converts drafts into access changes.
src/​components/​access-control-modal/​applyAccessChanges.ts Plans and applies scoped access changes.
src/​components/​access-control-modal/​accessTargetResolver.ts Resolves principals and search suggestions.
src/​components/​access-control-modal/​accessGrantDrafts.ts Builds grant drafts and derives roles.
src/​components/​access-control-modal/​AccessControlSharedAccess.ts Renders searchable shared-access controls.
src/​components/​access-control-modal/​AccessControlSharedAccess.styles.css Styles grant rows and role selectors.
src/​components/​access-control-modal/​AccessControlModal.ts Coordinates loading, editing, and saving access.
src/​components/​access-control-modal/​AccessControlModal.styles.css Styles modal layout and sharing states.
src/​components/​access-control-modal/​AccessControlGeneralAccess.ts Adds public and authenticated-access controls.
src/​components/​access-control-modal/​AccessControlGeneralAccess.styles.css Styles general-access sections.
src/​components/​access-control-modal/​AccessControlErrors.ts Presents access-save failures.
src/​components/​access-control-modal/​AccessControlErrors.styles.css Styles save-error details.
src/​components/​access-control-modal/​AccessControlAddAccess.ts Adds principal selection and pending grants.
src/​components/​access-control-modal/​AccessControlAddAccess.styles.css Styles principal input and pending grants.
src/​acl/​add-agent-buttons.ts Drags the public agent class rather than its icon.
README.md Documents navigation icons and confirmation containers.
package.json Bumps the release and supporting dependencies.

Review effort: Balanced

Comment on lines +22 to +25
...changedAccessGrants.flatMap(({ subjects, role }) =>
subjects.map(subject => ({
subject,
role,
${this.renderPendingAccessGrants()}
</div>
<solid-ui-combobox
class="access-role-select access-role-select--top"
Comment on lines +88 to +101
class="access-role-select access-role-select--compact access-role-select--general access-grants-role access-grants-role--editable access-role-select--authenticated"
.disabled=${this.disabled}
.value=${this.authenticatedAccessRoleValue}
@change=${this.onAuthenticatedRoleChange}
>
${this.renderAuthenticatedRoleOptions()}
</solid-ui-combobox>
`
}

private renderPublicModeSelector () {
return html`
<solid-ui-combobox
class="access-role-select access-role-select--compact access-role-select--general access-grants-role access-grants-role--editable access-role-select--public"
return this.accessContextSubjectUri === this.subjectUri && Boolean(this.accessContext) && !this.accessContextError
}

private canMutate (): boolean {
private renderAuthorizationRole (role: AccessRole, id: string) {
return html`
<solid-ui-combobox
class="access-role-select access-role-select--compact access-grants-role access-grants-role--editable ${role === 'Owner' ? 'access-grants-role--owner' : ''}"
.handleEditingClick=${this.fileExplorerContext.beginEditing}
.paneSupportsEditing=${this.fileExplorerContext.canEdit}
.canEdit=${this.canEdit}
.canManageAccess=${this.canManageAccess}
Comment on lines +70 to +77
color: var(--blue-400, #51A2FF);
border-radius: 5px;
background: var(--blue-50, #EFF6FF);
}

icon-lucide-globe {
stroke-width: 1.021px;
stroke: var(--blue-400, #51A2FF);
Comment on lines +86 to +93
color: var(--yellow-600, #D08700);
border-radius: 5px;
background: var(--yellow-100, #FEF9C2);
}

icon-lucide-lock-keyhole {
stroke-width: 1.021px;
stroke: var(--yellow-600, #D08700);
Comment thread src/utils/webIdUtils.ts
export function isWebIdUri (uri: NamedNode): boolean {
try {
const parsedURL = new URL(uri.uri)
return parsedURL.hash === '#me'
Comment thread src/widgets/buttons.ts
Comment on lines +580 to +584
if (confirmationContainer) {
popup.style.position = 'static'
popup.style.top = ''
Array.from(popup.querySelectorAll<HTMLButtonElement>('button'))
.find(button => button.textContent === 'Cancel')?.focus()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants