Repository navigation
v5.1.0 Npm publish - #930
Merged
Merged
Conversation
…6.0.0 pane-registry@5.0.1)
…6.0.0 pane-registry@5.0.1)
…6.0.0 pane-registry@5.0.1)
Manage Access Dialog
…6.0.0 pane-registry@5.0.1)
…6.0.0 pane-registry@5.0.1)
… into feat/access-input
…6.0.0 pane-registry@5.0.1)
… into feat/access-input
Co-authored-by: SharonStrats <9412507+SharonStrats@users.noreply.github.com>
Co-authored-by: SharonStrats <9412507+SharonStrats@users.noreply.github.com>
…istry@5.0.2-0) (latest: rdflib@2.4.1)
…istry@5.0.2-2) (latest: rdflib@2.4.1)
move pane menu item prepration to solid-ui
…istry@5.0.2-2) (latest: rdflib@2.4.1)
revert to sharing pane for release
…istry@5.0.2-2) (latest: rdflib@2.4.1)
fix the chat icon being too big
…istry@5.0.2-2) (latest: rdflib@2.4.1)
add showback option to support direct url
…istry@5.0.2-2) (latest: rdflib@2.4.1)
fix(acl): allow dragging Everyone directly from the sharing chooser
…istry@5.0.2-3) (latest: rdflib@2.4.1)
update solid-logic and pane-registry
add the default color from internal pane
…istry@5.0.2-3) (latest: rdflib@2.4.1)
code editor accessibility
…6.2.0 pane-registry@5.1.1)
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The authorization change planner loses grant identity and combined subject constraints, potentially broadening access and making grant removals ambiguous.
11 open issues
Preserve authorization identity and constraints when saving · New Add an accessible label to the role selector · New Add accessible labels to audience selectors · New Block access mutations while a save is in progress · New Label shared-access role controls with their subject · New Show desktop Edit independently of Manage Access permission · New Expose Manage Access for desktop containers · New Increase Public badge contrast · New Increase Private badge contrast · New Discover storage links before falling back to WebID ancestry · New Manage confirmation focus in both popup placement modes · New
What changed in this PR
Prepares solid-ui 5.1.0 for npm publication, adding reusable file-explorer and access-management interfaces alongside accessibility and widget improvements.
Changes:
- Adds explorer composition, navigation events, resource headers, and action menus.
- Introduces an access-control modal with grant drafts, target resolution, scoped saving, and error reporting.
- Improves editor accessibility, form labels, deletion confirmations, and navigation icons, with supporting tests and documentation.
| File | Description |
|---|---|
test/unit/widgets/forms/autocomplete/__snapshots__/autocomplete.test.ts.snap |
Updates remove-control accessibility snapshots. |
test/unit/widgets/buttons/iconLink.test.ts |
Tests Lucide navigation links and custom icons. |
test/unit/widgets/buttons.test.ts |
Tests confirmation placement and focus handling. |
test/unit/index.test.ts |
Updates expected public exports. |
test/unit/file-explorer/relevant-panes.test.ts |
Tests pane filtering and preference selection. |
test/unit/file-explorer/pane-menu-items.test.ts |
Tests pane actions and icon resolution. |
test/unit/codeEditor.test.js |
Tests editor accessibility and read-only configuration. |
test/unit/acl/add-agent-buttons.test.ts |
Tests public-access dragging and clicking. |
test/components/error-state.test.ts |
Tests error rendering and close events. |
test/components/compose-explorer.test.ts |
Tests explorer composition and nested event ownership. |
test/components/access-control-modal/buildAccessChanges.test.ts |
Tests access-change ordering. |
test/components/access-control-modal/accessTargetResolver.test.ts |
Tests target resolution and trusted-app suggestions. |
test/components/access-control-modal/accessGrantDrafts.test.ts |
Tests grant identity and role aggregation. |
src/widgets/forms/autocomplete/autocompletePicker.ts |
Handles missing autocomplete results. |
src/widgets/buttons/iconLinks.ts |
Uses Lucide icons for default navigation links. |
src/widgets/buttons.ts |
Adds external confirmations and deletion focus handling. |
src/utils/webIdUtils.ts |
Adds profile and owner-name lookup helpers. |
src/utils/podUtils.ts |
Adds storage discovery and container helpers. |
src/types/custom-elements.d.ts |
Adds element typings for new components. |
src/styles/theme.css |
Extends shared color tokens. |
src/lib/file-explorer/relevant-panes.ts |
Selects relevant and preferred panes. |
src/lib/file-explorer/pane-menu-items.ts |
Builds pane menu actions. |
src/lib/file-explorer/index.ts |
Exports explorer utilities. |
src/lib/file-explorer/events.ts |
Defines explorer events and ownership checks. |
src/lib/file-explorer/context.ts |
Defines editor registration and explorer state. |
src/lib/file-explorer/compose-explorer.ts |
Composes headers and pane content. |
src/lib/context/noopContext.ts |
Adds a missing-provider error proxy. |
src/lib/components/traits/FormControlTrait.ts |
Supports visually hidden labels. |
src/lib/components/form-control-component/FormControlComponent.ts |
Exposes the hidden-label property. |
src/lib/code-editor/CodeEditor.ts |
Adds accessibility settings and Tab indentation. |
src/index.ts |
Exports the explorer helper API. |
src/components/select/Select.stories.ts |
Demonstrates hidden labels. |
src/components/resource-actions-menu/ResourceActionsMenu.ts |
Adds resource and pane actions. |
src/components/resource-actions-menu/ResourceActionsMenu.test.ts |
Tests action visibility and dispatch. |
src/components/resource-actions-menu/ResourceActionsMenu.styles.css |
Styles the action-menu trigger. |
src/components/resource-actions-menu/index.ts |
Exports the action-menu component. |
src/components/resource-actions-menu/DeleteResourceDialog.ts |
Adds a deletion confirmation dialog. |
src/components/menu-item/MenuItem.styles.css |
Normalizes slotted icon sizing. |
src/components/input/Input.ts |
Adds a left-icon slot. |
src/components/input/Input.styles.css |
Styles input icons and configurable borders. |
src/components/input/Input.stories.ts |
Demonstrates hidden input labels. |
src/components/index.ts |
Registers the explorer provider early. |
src/components/file-explorer-provider/index.ts |
Exports the explorer provider. |
src/components/file-explorer-provider/FileExplorerProvider.ts |
Provides explorer and editor state. |
src/components/file-explorer-header/types.ts |
Defines header metadata types. |
src/components/file-explorer-header/index.ts |
Exports the explorer header. |
src/components/file-explorer-header/FileExplorerHeaderSummary.ts |
Renders resource details and navigation. |
src/components/file-explorer-header/FileExplorerHeaderSummary.styles.css |
Styles resource summaries and status badges. |
src/components/file-explorer-header/FileExplorerHeaderControls.ts |
Adds responsive editing and sharing controls. |
src/components/file-explorer-header/FileExplorerHeaderControls.styles.css |
Styles actions and unsaved-change indicators. |
src/components/file-explorer-header/FileExplorerHeader.ts |
Loads metadata and composes header components. |
src/components/file-explorer-header/FileExplorerHeader.styles.css |
Defines header layout. |
src/components/error-state/index.ts |
Exports the error-state component. |
src/components/error-state/ErrorState.ts |
Adds a reusable dismissible error alert. |
src/components/error-state/ErrorState.styles.css |
Styles error content and controls. |
src/components/error-state/ErrorState.stories.ts |
Demonstrates error and recovery presentations. |
src/components/combobox/Combobox.ts |
Applies disabled state and opens on click. |
src/components/combobox/Combobox.styles.css |
Adds focus indicators and configurable borders. |
src/components/combobox/Combobox.stories.ts |
Demonstrates hidden combobox labels. |
src/components/access-control-modal/types.ts |
Defines grant, event, and error types. |
src/components/access-control-modal/index.ts |
Exports the access-control modal. |
src/components/access-control-modal/helpers.ts |
Adds origin validation and deduplication helpers. |
src/components/access-control-modal/buildAccessChanges.ts |
Converts drafts into access changes. |
src/components/access-control-modal/applyAccessChanges.ts |
Plans and applies scoped access changes. |
src/components/access-control-modal/accessTargetResolver.ts |
Resolves principals and search suggestions. |
src/components/access-control-modal/accessGrantDrafts.ts |
Builds grant drafts and derives roles. |
src/components/access-control-modal/AccessControlSharedAccess.ts |
Renders searchable shared-access controls. |
src/components/access-control-modal/AccessControlSharedAccess.styles.css |
Styles grant rows and role selectors. |
src/components/access-control-modal/AccessControlModal.ts |
Coordinates loading, editing, and saving access. |
src/components/access-control-modal/AccessControlModal.styles.css |
Styles modal layout and sharing states. |
src/components/access-control-modal/AccessControlGeneralAccess.ts |
Adds public and authenticated-access controls. |
src/components/access-control-modal/AccessControlGeneralAccess.styles.css |
Styles general-access sections. |
src/components/access-control-modal/AccessControlErrors.ts |
Presents access-save failures. |
src/components/access-control-modal/AccessControlErrors.styles.css |
Styles save-error details. |
src/components/access-control-modal/AccessControlAddAccess.ts |
Adds principal selection and pending grants. |
src/components/access-control-modal/AccessControlAddAccess.styles.css |
Styles principal input and pending grants. |
src/acl/add-agent-buttons.ts |
Drags the public agent class rather than its icon. |
README.md |
Documents navigation icons and confirmation containers. |
package.json |
Bumps the release and supporting dependencies. |
Review effort: Balanced
Comment on lines
+22
to
+25
| ...changedAccessGrants.flatMap(({ subjects, role }) => | ||
| subjects.map(subject => ({ | ||
| subject, | ||
| role, |
| ${this.renderPendingAccessGrants()} | ||
| </div> | ||
| <solid-ui-combobox | ||
| class="access-role-select access-role-select--top" |
Comment on lines
+88
to
+101
| class="access-role-select access-role-select--compact access-role-select--general access-grants-role access-grants-role--editable access-role-select--authenticated" | ||
| .disabled=${this.disabled} | ||
| .value=${this.authenticatedAccessRoleValue} | ||
| @change=${this.onAuthenticatedRoleChange} | ||
| > | ||
| ${this.renderAuthenticatedRoleOptions()} | ||
| </solid-ui-combobox> | ||
| ` | ||
| } | ||
|
|
||
| private renderPublicModeSelector () { | ||
| return html` | ||
| <solid-ui-combobox | ||
| class="access-role-select access-role-select--compact access-role-select--general access-grants-role access-grants-role--editable access-role-select--public" |
| return this.accessContextSubjectUri === this.subjectUri && Boolean(this.accessContext) && !this.accessContextError | ||
| } | ||
|
|
||
| private canMutate (): boolean { |
| private renderAuthorizationRole (role: AccessRole, id: string) { | ||
| return html` | ||
| <solid-ui-combobox | ||
| class="access-role-select access-role-select--compact access-grants-role access-grants-role--editable ${role === 'Owner' ? 'access-grants-role--owner' : ''}" |
| .handleEditingClick=${this.fileExplorerContext.beginEditing} | ||
| .paneSupportsEditing=${this.fileExplorerContext.canEdit} | ||
| .canEdit=${this.canEdit} | ||
| .canManageAccess=${this.canManageAccess} |
Comment on lines
+70
to
+77
| color: var(--blue-400, #51A2FF); | ||
| border-radius: 5px; | ||
| background: var(--blue-50, #EFF6FF); | ||
| } | ||
|
|
||
| icon-lucide-globe { | ||
| stroke-width: 1.021px; | ||
| stroke: var(--blue-400, #51A2FF); |
Comment on lines
+86
to
+93
| color: var(--yellow-600, #D08700); | ||
| border-radius: 5px; | ||
| background: var(--yellow-100, #FEF9C2); | ||
| } | ||
|
|
||
| icon-lucide-lock-keyhole { | ||
| stroke-width: 1.021px; | ||
| stroke: var(--yellow-600, #D08700); |
| export function isWebIdUri (uri: NamedNode): boolean { | ||
| try { | ||
| const parsedURL = new URL(uri.uri) | ||
| return parsedURL.hash === '#me' |
Comment on lines
+580
to
+584
| if (confirmationContainer) { | ||
| popup.style.position = 'static' | ||
| popup.style.top = '' | ||
| Array.from(popup.querySelectorAll<HTMLButtonElement>('button')) | ||
| .find(button => button.textContent === 'Cancel')?.focus() |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


No description provided.