Repository navigation
SONARJAVA-7279 Resolve the JDK API of the target release through the new jdt-package option - #6459
Conversation
|
⚖️ Ruling update ready for review: #6461 |
This comment has been minimized.
This comment has been minimized.
|
|
/pvf |
|
Projects with unexpected PVF results:
|
Ruling Diff SummaryDetected changes in 5 rule files: 30 issues removed, 2 issues added. S5738 (
|
david-schroeter
left a comment
There was a problem hiding this comment.
Thanks for this changes, it's a huge improvement to be able to use the correct release version.
I just have a few small comments and questions.
ed8a92f to
3532398
Compare
…he target release Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> # Conflicts: # java-frontend/src/main/java/org/sonar/java/JavaFrontend.java # java-frontend/src/main/java/org/sonar/java/ast/JavaAstScanner.java # java-frontend/src/main/java/org/sonar/java/jdt/JDTParser.java # java-frontend/src/test/java/org/sonar/java/model/JParserTest.java
david-schroeter
left a comment
There was a problem hiding this comment.
LGTM! Thanks for addressing the comments!
3532398 to
822819f
Compare
Code Review ✅ Approved 🟡 Medium risk 6 closed / 6 findingsThe parser now limits visible JDK APIs to the target release by default, which could change semantic resolution and findings across Java analyses. Resolves the JDK API of the target release through the jdt-package release option via ✅ 6 closed✅ Quality: SequencedCollection mutators of CollectorsToListCheck lose all coverage
✅ Quality: Merge drops release-option ruling coverage and its updated expectations
✅ Cross-PR: Merge downgrades jdt-package and drops master's Java 27 JDT update
✅ Cross-PR: Release-option plumbing lost after merging with #6485's JDT refactor
✅ Cross-PR: #6517's JDTParser drops JDK release option, so analysis uses the JVM's API
...and 1 more closed from earlier reviews Verification Rules 2/3 met Repos 6 inspectedRules 1 failed 2 passed 2 not applicable
Functional validation No results Broader impact Repos 6 inspectedCross-repo 6 repositories inspected 0 open impacts
1 more repository Auto-approval Not enabledFor more verification details, comment OptionsAuto-apply is off → Gitar will not commit updates to this branch. Comment with these commands to change the behavior for this request:
Was this helpful? React with 👍 / 👎 | Gitar |
|




Summary by Gitar
SystemReleaseClasspathinJParserConfig, replacingjrt-fs.jaron the classpath with the JDK homesonar.java.useJdkReleaseOptionproperty, enabled by default and registered inJavaPluginjdt-packageto2.0-SNAPSHOTinjava-frontend/pom.xmlRunFinalizersCheckTestexpectations for Java 10 API visibilitySequencedCollectionmutator calls withListequivalents inCollectorsToListCheckSampleCollectorsToListCheckSequencedSamplecoveringSequencedCollectionmutators on Java 21S5738andS2387expectationsguavaS3551expectationsThis will update automatically on new commits.