Repository navigation
fix(windows): open each data grid edit in a new TextBox so it never takes the last cell's height - #4380
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Heightfor 100 ms when its size changes while it has focus, has noHeight, and wraps or takes returns. When the animation ends it setsHeightto NaN (TextBox::OnSizeChanged,dxaml/xcp/dxaml/lib/TextBox_Partial.cpp).Heightwhen the animation ended. This keptTheEditorCoversAWrappedRowAndWrapsItsTextAndWithWrapOffIsOneRowAgainfrom feat(datagrid): wrap long values onto several lines in the data grid #4378 failing on main.CUIElement::IsFocusable), so keys typed right after F2 or Tab reach it. Loaded focuses only a box still without focus, so it never selects over typed text.Test plan
EachEditOpensAtItsOwnRowsHeightAfterATallerOne. On main the reused box measured 74 to 89 px there instead of 32, and itsHeightturned NaN (probe run 44783975649, x64 and Arm64).TheEditorHasFocusAsItOpensAndKeepsWhatIsTypedBeforeItLoads: focus and selection right afterBeginEdit, and the caret kept after Loaded.TheEditorCoversAWrappedRowAndWrapsItsTextAndWithWrapOffIsOneRowAgain: main's code failed it 4 of 5 runs on each runner (run 44783975649). With this change,EditingTestspassed 10 of 10 runs on each runner, and the whole grid suite passed (run 44788178582).TabCommitsAndEditsTheNextCellandAValueWithMixedLineBreaksOpenedAndLeftRaisesNothingkept the first edit's TextBox for the next edit. They now readgrid.Editorfor each edit.