Skip to content

refactor(macos): dispatch Cypher by declared language, check curated plugin metadata, share HostKeyStore - #4399

Open
datlechin wants to merge 4 commits into
mainfrom
refactor/audit-slices
Open

datlechin wants to merge 4 commits into
mainfrom
refactor/audit-slices

Conversation

@datlechin

@datlechin datlechin commented Nov 21, 2026 •

Copy link
Copy Markdown
Member

Summary

  • AR-05 (a): Cypher is chosen by the editor language an engine declares, not by case .neo4j: classification, unfiltered-delete, Edit mode's data commands and catalog refresh (QueryClassifier.speaksCypher). A non-Neo4j engine declaring .custom("cypher") no longer falls to the SQL rules, where an unknown keyword is a write. For an engine the app curates, the curated language wins, so a plugin cannot move a SQL engine onto the Cypher reading.
  • AR-05 (a): such an engine also lexes as Cypher (-- is a pattern, not a comment): SQLLexicalProfile.curated(forQueryLanguage:), and SQLLexicalReadings.resolve takes the language after the type id.
  • AR-05 (b) and AR-03: apple/scripts/ci/check-source-ratchets.py fails Lint when engine-name comparisons under apple/TablePro/, or DatabaseManager/PluginManager/AppSettingsManager .shared reads under Views/ and ViewModels/, rise above source-ratchets.json. The patterns are defined in the script's docstring.
  • AR-06: PluginMetadataCuratedParityTests loads every driver plugin built beside the test host, builds its snapshot as registration does (metadataSnapshot(from:isDownloadable:existing:), adoptingCuratedEntry, both extracted from the registry) and fails on every field that differs from the curated entry. CI's macOS Tests job builds AllPlugins before the Unit plan; the plugins suite now also runs on a curated-entry change.
  • AR-06: the curated entries now declare what their plugins declare, which is what the app already used once a plugin loaded: capabilities, schema names, dialect lists, completions, column types and connection fields. A curated explain list stays empty where it is (it is only the fallback for a plugin that declares none). PostgreSQL's 555 keywords move into SQLEngineVocabulary.postgreSQL.keywords, which the plugin and the app both read.
  • AR-06: the ClickHouse, Redis (rediss), SQL Server, Oracle, Teradata and Trino plugins declare the URL schemes the app already parses; SQL Server registered sql server as its scheme. The SurrealDB plugin declares the completions only the curated entry had.
  • AR-06: removed as redundant: check-capability-parity.py with its tests and Lint step, ClickHouseDialectParityTests.pluginAndCuratedTableAgree, and the MySQL row of MySQLConnectionEncodingParityTests (MariaDB, a variant, stays).
  • AR-11 (a): ADR 0043 adds the later slices to 0010: importers after slices 2 and 3, the MCP server after slice 5, SSH with each engine. A new ADR rather than an edit to 0010's body, per core/docs/decisions/README.md.
  • AR-11 (b): one HostKeyStore in TableProSSHTransport with the file path passed in; each app keeps its own path (macOS <storage root>/TablePro/known_hosts, iOS <Application Support>/known_hosts), pinned by a test. The two app copies and their tests are gone; the tests live in the package.

Test plan

  • QueryClassifierCypherLanguageTests: a registered non-Neo4j engine declaring Cypher reads MATCH ... RETURN as a read, tiers writes as Neo4j does, lexes as Neo4j; the same engine declaring SQL reads MATCH as a write.
  • SQLLexicalReadingsTests, HostKeyStoreTests (TableProSSHTransportTests), HostKeyStorePathTests (both apps).
  • PluginMetadataCuratedParityTests on CI with every plugin built.
  • test_check_source_ratchets.py, test_detect_changed_paths.py.
  • Updated on purpose: HierarchicalSchemaSearchCostTests, SchemaRefreshCommitCostTests and SchemaServiceStaleSchemaTests count the trigger read Oracle's curated entry now browses, as the Oracle plugin does.

Refs #4272, #4273, #4274

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant