Repository navigation
Conversation
…plugin metadata, share HostKeyStore
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
case .neo4j: classification, unfiltered-delete, Edit mode's data commands and catalog refresh (QueryClassifier.speaksCypher). A non-Neo4j engine declaring.custom("cypher")no longer falls to the SQL rules, where an unknown keyword is a write. For an engine the app curates, the curated language wins, so a plugin cannot move a SQL engine onto the Cypher reading.--is a pattern, not a comment):SQLLexicalProfile.curated(forQueryLanguage:), andSQLLexicalReadings.resolvetakes the language after the type id.apple/scripts/ci/check-source-ratchets.pyfails Lint when engine-name comparisons underapple/TablePro/, orDatabaseManager/PluginManager/AppSettingsManager.sharedreads underViews/andViewModels/, rise abovesource-ratchets.json. The patterns are defined in the script's docstring.PluginMetadataCuratedParityTestsloads every driver plugin built beside the test host, builds its snapshot as registration does (metadataSnapshot(from:isDownloadable:existing:),adoptingCuratedEntry, both extracted from the registry) and fails on every field that differs from the curated entry. CI's macOS Tests job buildsAllPluginsbefore the Unit plan; thepluginssuite now also runs on a curated-entry change.SQLEngineVocabulary.postgreSQL.keywords, which the plugin and the app both read.rediss), SQL Server, Oracle, Teradata and Trino plugins declare the URL schemes the app already parses; SQL Server registeredsql serveras its scheme. The SurrealDB plugin declares the completions only the curated entry had.check-capability-parity.pywith its tests and Lint step,ClickHouseDialectParityTests.pluginAndCuratedTableAgree, and the MySQL row ofMySQLConnectionEncodingParityTests(MariaDB, a variant, stays).core/docs/decisions/README.md.HostKeyStoreinTableProSSHTransportwith the file path passed in; each app keeps its own path (macOS<storage root>/TablePro/known_hosts, iOS<Application Support>/known_hosts), pinned by a test. The two app copies and their tests are gone; the tests live in the package.Test plan
QueryClassifierCypherLanguageTests: a registered non-Neo4j engine declaring Cypher readsMATCH ... RETURNas a read, tiers writes as Neo4j does, lexes as Neo4j; the same engine declaring SQL readsMATCHas a write.SQLLexicalReadingsTests,HostKeyStoreTests(TableProSSHTransportTests),HostKeyStorePathTests(both apps).PluginMetadataCuratedParityTestson CI with every plugin built.test_check_source_ratchets.py,test_detect_changed_paths.py.HierarchicalSchemaSearchCostTests,SchemaRefreshCommitCostTestsandSchemaServiceStaleSchemaTestscount the trigger read Oracle's curated entry now browses, as the Oracle plugin does.Refs #4272, #4273, #4274