Repository navigation
Conversation
…nor a Stop queued before it starts
datlechin
enabled auto-merge (squash)
November 21, 2026 13:39
2 of 6 tasks
datlechin
disabled auto-merge
November 21, 2026 13:47
…on on a connection of its own
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DuckDBPluginDriverbehindPluginBackedDriver(DuckDBBackedDriver), compiled as a source path like ClickHouse, D1 and MongoDB. The six hand-writtenDuckDBDriver*.swiftfiles andDuckDBTransferEngine.swiftare gone; exports ask the plugin throughPluginTransferCatalog, as the Mac's adapter does.DuckDBBackedDriverkeeps the iOS file handling: app files, picked (security-scoped) files and in-memory databases, create-new for the file creator, access ended only after DuckDB closed the file, and the suspension flag for a file session.DuckDBChunkValue,DuckDBBackedDriver.gridReader): long text is copied up to its preview, a BLOB only counted, a key column kept whole. Rows go out throughPluginRowEmitter, shared withPluginBackedDriver.emit.DuckDBExtensionPolicy).close()returns once the file is closed; ping answers inside an aborted transaction; a NUL in a literal goes in aschr(0); an empty BLOB parameter binds an empty blob instead of NULL.PluginBackedDriver: an aborted transaction reports.abortedTransactioninstead of an open one, andholdsSuspensionBlockingResourcecan be overridden.PluginTransferCatalog: DuckDB lists macros from the schema the export reads, as the Mac's loader does.executespells a BLOB in hex like the other plugin-backed engines, and schemas list the current catalog only.DuckDBGridDecodeTests(values cut at decode, characters kept whole, budget, BLOB counted, a real plugin read),DuckDBTransferEngineTestspaused and whole transfer reads and cross-schema macros;sessionExportSurvivesGridStatementsnow reads 400,000 rows, past the 64-batch buffer.DuckDBDriverTests(native stream internals replaced by stream, cap and Stop behavior; several-statement and BLOB-hex cases pin the Mac behavior above),DuckDBDriverSuspensionTests,DuckDBSideEffectingBindTests,DuckDBTransferEngineTests,LazyCellKeyTests,ExportTwinNameTests,IOSDriverFactoryLocalFileTests,DuckDBReadOnlyStatementTests,DuckDBSafeModeReadOnlyTests.Refs #4272 (IO-09, first of seven engines).
Test plan
verify.sh ioswith the DuckDB, transfer, lazy-cell, factory and plugin-backed suites.verify.sh pluginsbuilds the DuckDB plugin for macOS.