Repository navigation
Conversation
… the core The completion scope, catalog read, fuzzy ranking and formatter are copied from linux/crates/app into core; Linux moves onto them after its 0.1.0 tag (ROADMAP C-07, C-08).
…nd scope aliases by query
…o numbers, rank a stale accept off the UI thread
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tablepro_core::sql_syntax::completion(caret scope, fuzzy ranking, word start) andsql_syntax::format(the formatter, with caret mapping and selection formatting), andtablepro_session::completion::read_catalog. These are copies of the Linux app'scompletion_scope.rs,fuzzy.rs,catalog_read.rs,format_plan.rsandsignificant_tokens.rs.linux/is not touched: Linux moves onto them after its 0.1.0 tag (ROADMAP C-07, C-08).DatabaseSession::complete(text, caret, asked, database)returns aCompletionListthat ranks again for each word typed.format_sqlandformat_sql_selectionare free functions. Bindings are regenerated.Popupwith aListViewthat never takes focus. It opens 50 ms after a letter, or after a space, comma, dot or(where the place takes a name. Ctrl+Space opens it anywhere. Up, Down, Page Up, Page Down, Enter, Tab and double click work, and with Vim on these keys reach the list before Vim. The editor raises a UIA notification for the selected row.core/ARCHITECTURE.md, Bindings;windows/AGENTS.md.Test plan
tablepro-core, catalog home tests intablepro-session, and intablepro-ffithe UTF-16 offsets, keyword casing and a real SQLite file (tables, quoted names, alias columns, another database).CompletionTests(interop against SQLite and the formatter),ReplaceTests(editor model).CompletionOffersTheCatalogAndTakesTheChosenName,FormatQueryReflowsTheTextAsOneUndoStepandFormatQueryReflowsTheSelectionAloneFromTheQueryMenu, in light and dark, with screenshots 188 to 191.Fixes #4275