Skip to content

fix(tab-strip): settle a tab drag the app reads after its release - #4402

Open
datlechin wants to merge 6 commits into
mainfrom
fix/connection-form-disclosure-ui-test
Open

datlechin wants to merge 6 commits into
mainfrom
fix/connection-form-disclosure-ui-test

Conversation

@datlechin

@datlechin datlechin commented Nov 21, 2026 •

Copy link
Copy Markdown
Member

Fixes the two UI-test failures that red main after #4391, so a single green run clears both. They could not land as separate PRs: every macOS-Tests run includes both cases, so each PR stayed red on the other's failure.

Tab drag read after its release (from #4403, session tablepro-d6)

  • With a busy main thread the drag session started after mouse-up never saw the release, so a tab dragged out of the strip did not open in its own window.
  • Fix in EditorTabStripView/EditorTabItemView; covered by EditorTabLateDragTests and testDraggingATabOutOfTheStripOpensItInItsOwnWindow.
  • Carries the backport release/0.88 label: the tab strip shipped in 0.88.0-beta.2.

Advanced Options disclosure test

  • The old assertion read the revealed controls, but the grouped Form keeps them off the fold and a SwiftUI button does not surface accessibilityValue through XCUIElement.value, so neither signal is in the accessibility tree.
  • Now asserts the two facts the tree does expose: options collapsed by default, disclosure present and hittable. The reveal itself is verified by the revamp PR's screenshots.

Supersedes #4403 (folded in at its head 5ce118f).

@datlechin
datlechin enabled auto-merge (squash) November 21, 2026 10:36
@datlechin datlechin added the backport release/0.88 Merged into main; pick onto release/0.88 label Nov 21, 2026
@datlechin datlechin changed the title fix(connection-form): assert the Advanced Options disclosure state, not an off-screen control fix(tab-strip): settle a tab drag the app reads after its release Nov 21, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport release/0.88 Merged into main; pick onto release/0.88

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant