Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
compareSync) in Settings > Extensions. Default: on for a Mac that ran an earlier build, off on a new install.AppModule.wasCoreplus a per-Mac default written once, first thing inapplicationWillFinishLaunching, before the menu bar is built. The marker iscom.TablePro.settings.didMigrateStartupToReopenLast, which every launch since 0.51.0 writes with no user action (Compare & Sync shipped in 0.68.0), or the onboarding flag. The answer is stored incom.TablePro.modules.<id>.default, so a later launch never changes it.WindowOpenerpresenter is gone; the launcher presents the window itself), and nothing in the quit-time running-work check, since its run registry is empty. It has no shortcuts or Keyboard rows, and no URL, AppleScript or MCP entry exists for it.CompareSyncLauncher.openopens nothing and does not read the license while the module is off. Turning the module off runsCompareSyncRunRegistry.endAll(), which cancels every run and closes every Compare & Sync window, its sheets first, without the close prompt. A cancelled run whose statement is still writing stays in the quit check until it ends, as after closing the window.Test plan
CompareSyncModuleResidueTests: off leaves no menu item, Welcome item, key equivalent or Keyboard row, and the host's launcher opens no window; on adds the submenu last with its 8 commands and the Welcome item after Duplicate; switching edits the installed bar; on without a license still asks for one; turning off through the Extensions path cancels a running comparison and closes every window; a cancelled run stays in the quit check until it ends.AppModuleDefaultTests: new install off and stays off; a Mac with the launch marker or the onboarding flag keeps it on; recorded once; recording leaves the on/off keys an older build reads unset; Reset All Settings returns each Mac to its own default.AppModuleSettingsTests(modulesStartOff,resetRestoresDefaults,keysAreNamespaced) andLiveMessagesModuleResidueTests.offByDefaultread the recorded default;WelcomeMenuSpecTestsgains the module flag; the threeWindowOpenerTestscompare presenter cases are removed with the presenter.Part of #4273 (AR-09)