Repository navigation
feat(NOJIRA): add opt-in cache-from and cache-to inputs to image-multiarch - #288
Closed
adriancarayol wants to merge 1 commit into
Closed
adriancarayol wants to merge 1 commit into
adriancarayol wants to merge 1 commit into
Conversation
…iarch Each job builds with a throwaway buildx builder and no external cache, so every image build starts from zero. The two new inputs are passed to docker/build-push-action as they are. Both default to empty, so callers that don't set them build exactly as before. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Author
|
Closing: measured in Typeform/renderer#1773, a Louvre build with every install layer served from the registry cache took 8.8 minutes, against 7 to 11 minutes without it. Pulling the multi-GB node_modules layers costs about as much as installing them, and uploading the cache added 11.6 minutes when dependencies changed. No evidence the inputs help, so not adding them. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Jira ticket: NOJIRA
image-multiarch.yamlcreates a throwaway buildx builder in every job and passes no external cache, so every image build starts from zero. InTypeform/rendererthe Louvre image takes 7 to 11 minutes per PR run, about 5 of them reinstalling the same dependencies.This adds two opt-in inputs so a caller can point the build at a layer cache, for example in the service's own ECR repository.
Changes
cache-fromandcache-to, passed as they are todocker/build-push-actionin the "Build and push images" step.Example caller:
Testing
actionlintreports nothing new on the file.Typeform/renderercalls this branch directly to measure a cold and a warm Louvre build. I will link it and add the numbers here.Docs
🤖 Generated with Claude Code