Repository navigation
Remove unused keptThoughts (#687) - #689
Merged
Merged
Conversation
The view calls thoughtsOf on rows it already read; keptThoughts had no caller since #680. Its unit test now checks thoughtsOf(readHead(...)) with the same assertions. Written by the team (Sonnet lead, Haiku worker) on the rig. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XC62LX3AUpPAHPUXeDZTmz
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #687.
chat_view.html:keptThoughtsremoved. It had no caller since AI chat view in the mock's look, with rendering tests (#609) #680; the view callsthoughtsOfon rows it already read.chat_view_logic.test.ts:thoughtsOftakeskeptThoughts' place in the test api. The paging test now checksthoughtsOf(await readHead(call, 2)), with the same assertions, including the null answer.Written by the team's CLI on the rig (Sonnet 5.5 lead, one Haiku 5.5 worker) as a paid trial run.
Checked on the laptop:
node --test tests/chat_view_logic.test.ts19/19, all canvas node tests 561/561, canvas typecheck clean.🤖 Generated with Claude Code
https://claude.ai/code/session_01XC62LX3AUpPAHPUXeDZTmz