Skip to content

feat: Remote rendering 5.2d - Batch visibility and selection requests from client - #227

Open
LKasianAnsys wants to merge 3 commits into
feat/5.2c-wire-paraview-mode-in-visorfrom
feat/5.2d-batch-visibility-and-selection
Open

LKasianAnsys wants to merge 3 commits into
feat/5.2c-wire-paraview-mode-in-visorfrom
feat/5.2d-batch-visibility-and-selection

Conversation

@LKasianAnsys

@LKasianAnsys LKasianAnsys commented Nov 16, 2026 •

Copy link
Copy Markdown
Collaborator

Issue

Resolves #34

Summary

Batches selection requests from the browser when selecting parent nodes from the tree view, and when deselecting by a click on the canvas. Also batches visibility requests when more than more than one part is selected.

Updates

Two new triggers: set_parts_visibility and set_parts_selected. Each takes { parts: [{ nodeId, visible | selected }] }.

  • Each entry is an absolute target value, not a toggle.
  • If any entry fails validation, the server rejects the whole batch.
  • Selection batches don't carry a colour. The server uses each part's stored diffuse colour, the same as the single-part trigger.

Server (VisorSceneBase): The existing single-part logic is moved into shared helpers, so a batch applies each part exactly as the single-part path does.

  • A node ID the server can't find is logged and skipped. It doesn't stop the rest of the batch.
  • For visibility, widget bounds and the actor count are recalculated once per batch instead of once per part.

Client: The scene graph has new setVisiblePartsAsync and setSelectedPartsAsync methods.

  • Each part is updated locally first. Only the parts that actually changed are sent, in one batch, and nothing is sent if none changed.
  • The tree listeners, viewport click selection and the selection-mode reset now use these methods instead of looping over parts.

Manual check

  • Start VISOR in PARAVIEW or SERVER mode (CLIENT mode should appear unaffected, as the per-part selection/visibility cost was very small to begin with)
  • Start with tests/files/many_blocks/many_blocks.vtm
  • Select all parts in the tree view. Selection across all parts should appear at the same time. (previously they would appear one at a time)
  • Select the canvas background (click twice in PARAVIEW mode; this is a known issue). Selection highlights should disappear from all parts, all at once.
  • Click on the visibility icon for the top level dataset node. The parts should disappear all at once.

@github-actions github-actions Bot added documentation Improvements or additions to documentation test Work associated with testing added enhancement New feature or request labels Nov 16, 2026
@LKasianAnsys
LKasianAnsys changed the base branch from main to feat/5.2c-wire-paraview-mode-in-visor November 16, 2026 21:42
@LKasianAnsys
LKasianAnsys added this pull request to stack #224 November 16, 2026 21:42
@github-actions github-actions Bot removed the documentation Improvements or additions to documentation label Nov 16, 2026
@LKasianAnsys LKasianAnsys self-assigned this Nov 16, 2026
@LKasianAnsys
LKasianAnsys force-pushed the feat/5.2d-batch-visibility-and-selection branch from 9b5f4bd to b9b7efc Compare November 17, 2026 14:17
@LKasianAnsys
LKasianAnsys removed this pull request from stack #224 November 17, 2026 16:25
@LKasianAnsys
LKasianAnsys added this pull request to stack #233 November 17, 2026 16:26
@LKasianAnsys
LKasianAnsys force-pushed the feat/5.2d-batch-visibility-and-selection branch from b9b7efc to 308be1e Compare November 17, 2026 17:41
@LKasianAnsys
LKasianAnsys force-pushed the feat/5.2d-batch-visibility-and-selection branch from 308be1e to 7710700 Compare November 17, 2026 20:06
@LKasianAnsys
LKasianAnsys force-pushed the feat/5.2d-batch-visibility-and-selection branch from 7710700 to bd72dfb Compare November 17, 2026 20:25
@LKasianAnsys
LKasianAnsys force-pushed the feat/5.2d-batch-visibility-and-selection branch from bd72dfb to 9c7da54 Compare November 18, 2026 19:02
@LKasianAnsys
LKasianAnsys marked this pull request as ready for review November 18, 2026 20:20
@LKasianAnsys LKasianAnsys linked an issue Nov 18, 2026 that may be closed by this pull request

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

added enhancement New feature or request test Work associated with testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Remote rendering 5.2] Add ParaView mode to VISOR: MVP

2 participants