Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
Because the change modifies low-level concurrent key lifecycle synchronization and destructor cleanup, and the commit could not be rebuilt or stress-tested here, human runtime validation remains necessary.
No open issues 🎉
What changed in this PR
Fixes races in bthread key metadata during key creation, deletion, reuse, and thread-local cleanup while preserving destructor reentrancy.
Changes:
- Synchronizes key metadata updates and destructor snapshots with the key mutex.
- Makes key versions atomic for lock-free validation.
- Invokes destructors after releasing the mutex.
- Adds regression tests for key reuse during thread exit and destructor-driven key recreation.
| File | Description |
|---|---|
| test/bthread_key_unittest.cpp | Adds regression tests covering key reuse during thread exit and key recreation from destructors. |
| src/bthread/key.cpp | Synchronizes key metadata lifecycle operations, uses atomic key versions, and invokes destructors outside the metadata mutex. |
Review effort: Lite
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: resolve
Problem Summary:
Key creation, deletion, and key-table cleanup can concurrently access the same
key metadata without synchronization. When a key slot is reused while a thread
exits, cleanup may observe inconsistent version, destructor, and argument
values.
What is changed and the side effects?
Changed:
mutex.
bthread_setspecificcheck.Side effects:
Performance effects: Key-table cleanup now acquires the key mutex when it
processes a non-null value. The impact has not been benchmarked.
Breaking backward compatibility: No API changes.
Check List:
current commit was blocked by a missing macOS SDK in the local configuration.